Refactor and enhance Pester tests batch #9755
Open
+1,390
−885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardized parameter quoting, variable naming, and splatting across test scripts. Improved error handling and cleanup in integration tests, replaced deprecated syntax, and enhanced readability and maintainability. No functional changes to the tested modules.
Standardized the use of $PSDefaultParameterValues to enable exceptions during setup and cleanup in integration tests across multiple test files. Added and clarified comments, improved variable scoping, and ensured proper cleanup of test artifacts and directories. This improves test reliability and consistency.
Updated Invoke-DbatoolsFormatter to use custom PSSA settings that preserve manually aligned hashtables and assignment operators. The script now only writes files if formatting changes are detected, reducing unnecessary file writes.
Added checks to skip directories and non-PowerShell files, improved error handling for file read/write operations, and ensured only valid content is processed. These changes enhance robustness and prevent errors when processing invalid or unreadable files.
Enhances the formatter to compare processed, formatted content rather than raw content, ensuring that only meaningful formatting changes trigger file writes. Also applies CBH (Comment-Based Help) fixes and whitespace normalization to both the original and formatted content for accurate comparison.
Simplifies the formatter by removing custom alignment-preserving settings and redundant code. Now uses a placeholder approach to preserve aligned assignments, streamlines file type checks, and only writes files if actual formatting changes are detected. Improves maintainability and reliability of the formatting process.
Enhanced Invoke-DbatoolsFormatter to display progress when formatting multiple files, including status updates for each file, error handling, and a summary of processed and updated files. This improves user feedback during batch operations.
This commit addresses whitespace, indentation, and minor style inconsistencies across multiple test scripts. No functional changes were made; these updates improve code readability and maintain consistent formatting throughout the test suite.
potatoqualitee
changed the title
Simplified and cleaned up integration tests in Add-DbaDbMirrorMonitor.Tests.ps1 by removing redundant parameter handling and streamlining setup/teardown logic. In Connect-DbaInstance.Tests.ps1, variable naming was improved, unnecessary array casts were removed, and minor comment and assertion updates were made for clarity and consistency.
Added checks for the existence of backup files before attempting to remove them in Connect-DbaInstance integration tests. This prevents errors if the backup file does not exist.
Added the -IgnoreFileChecks parameter to Backup-DbaDatabase calls in integration tests to bypass file checks. This ensures the tests run without file validation issues.
Updated the test to check for at least 3 results and verify that each expected certificate is present, rather than requiring exactly 3 results. This makes the test more robust to additional certificates.
This reverts commit 9fe7433.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardized parameter quoting, variable naming, and splatting across test scripts. Improved error handling and cleanup in integration tests, replaced deprecated syntax, and enhanced readability and maintainability. No functional changes to the tested modules.