Refactor and enhance Pester tests batch #9758
Open
+2,301
−879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored Pester tests for various Get-DbaDbMail* and related commands to use parameterized test headers, static command names, and improved parameter validation. Updated integration tests to use BeforeAll/AfterAll blocks for setup and cleanup, improved assertions, and standardized test structure for consistency and maintainability.
Updated Invoke-DbatoolsFormatter to use custom PSSA settings that preserve manually aligned hashtables and assignment operators. The script now only writes files if formatting changes are detected, reducing unnecessary file writes.
Added checks to skip directories and non-PowerShell files, improved error handling for file read/write operations, and ensured only valid content is processed. These changes enhance robustness and prevent errors when processing invalid or unreadable files.
Enhances the formatter to compare processed, formatted content rather than raw content, ensuring that only meaningful formatting changes trigger file writes. Also applies CBH (Comment-Based Help) fixes and whitespace normalization to both the original and formatted content for accurate comparison.
Simplifies the formatter by removing custom alignment-preserving settings and redundant code. Now uses a placeholder approach to preserve aligned assignments, streamlines file type checks, and only writes files if actual formatting changes are detected. Improves maintainability and reliability of the formatting process.
Enhanced Invoke-DbatoolsFormatter to display progress when formatting multiple files, including status updates for each file, error handling, and a summary of processed and updated files. This improves user feedback during batch operations.
Removed trailing spaces and standardized whitespace in Get-DbaDbMailConfig.Tests.ps1 and Get-DbaDbRecoveryModel.Tests.ps1 for improved code consistency.
This commit standardizes whitespace, indentation, and minor formatting across multiple Pester test scripts for dbatools commands. No functional changes were made; these updates improve code consistency and readability.
Refactored integration tests for Get-DbaDbObjectTrigger, Get-DbaDbRestoreHistory, Get-DbaDbSequence, Get-DbaDbSharePoint, and Get-DbaDbUserDefinedTableType. Changes include improved variable naming, use of splatting for command parameters, removal of redundant comments, consolidation of repeated code, and more consistent assertions. These updates enhance readability, maintainability, and reliability of the test suites.
Standardized usage of double quotes for PSDefaultParameterValues keys and removed unnecessary comments. Improved cleanup in AfterAll by adding -ErrorAction SilentlyContinue to DROP TYPE queries. Fixed assertions to check the correct property for result counts.
|
Hell yeah, Sonnet came through, this is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Pester tests for various Get-DbaDbMail* and related commands to use parameterized test headers, static command names, and improved parameter validation. Updated integration tests to use BeforeAll/AfterAll blocks for setup and cleanup, improved assertions, and standardized test structure for consistency and maintainability.