Refactor and enhance Pester tests batch

.aitools/module/Get-AppVeyorFailure.ps1

@@ -0,0 +1,172 @@
+function Get-AppVeyorFailure {
+    <#
+    .SYNOPSIS
+        Retrieves test failure information from AppVeyor builds.
+
+    .DESCRIPTION
+        This function fetches test failure details from AppVeyor builds, either by specifying
+        pull request numbers or a specific build number. It extracts failed test information
+        from build artifacts and returns detailed failure data for analysis.
+
+    .PARAMETER PullRequest
+        Array of pull request numbers to process. If not specified and no BuildNumber is provided,
+        processes all open pull requests with AppVeyor failures.
+
+    .PARAMETER BuildNumber
+        Specific AppVeyor build number to target instead of automatically detecting from PR checks.
+        When specified, retrieves failures directly from this build number, ignoring PR-based detection.
+
+    .NOTES
+        Tags: Testing, AppVeyor, CI, PullRequest
+        Author: dbatools team
+        Requires: AppVeyor API access, gh CLI
+
+    .EXAMPLE
+        PS C:\> Get-AppVeyorFailure
+        Retrieves test failures from all open pull requests with AppVeyor failures.
+
+    .EXAMPLE
+        PS C:\> Get-AppVeyorFailure -PullRequest 9234
+        Retrieves test failures from AppVeyor builds associated with PR #9234.
+
+    .EXAMPLE
+        PS C:\> Get-AppVeyorFailure -PullRequest 9234, 9235
+        Retrieves test failures from AppVeyor builds associated with PRs #9234 and #9235.
+
+    .EXAMPLE
+        PS C:\> Get-AppVeyorFailure -BuildNumber 12345
+        Retrieves test failures directly from AppVeyor build #12345, bypassing PR detection.
+    #>
+    [CmdletBinding()]
+    param (
+        [int[]]$PullRequest,
+
+        [int]$BuildNumber
+    )
+
+    # If BuildNumber is specified, use it directly instead of looking up PR checks
+    if ($BuildNumber) {
+        Write-Progress -Activity "Get-AppVeyorFailure" -Status "Fetching build details for build #$BuildNumber..." -PercentComplete 0
+        Write-Verbose "Using specified build number: $BuildNumber"
+
+        try {
+            $apiParams = @{
+                Endpoint = "projects/dataplat/dbatools/builds/$BuildNumber"
+            }
+            $build = Invoke-AppVeyorApi @apiParams
+
+            if (-not $build -or -not $build.build -or -not $build.build.jobs) {
+                Write-Verbose "No build data or jobs found for build $BuildNumber"
+                Write-Progress -Activity "Get-AppVeyorFailure" -Completed
+                return
+            }
+
+            $failedJobs = $build.build.jobs | Where-Object Status -eq "failed"
+
+            if (-not $failedJobs) {
+                Write-Verbose "No failed jobs found in build $BuildNumber"
+                Write-Progress -Activity "Get-AppVeyorFailure" -Completed
+                return
+            }
+
+            $totalJobs = $failedJobs.Count
+            $currentJob = 0
+
+            foreach ($job in $failedJobs) {
+                $currentJob++
+                $jobProgress = [math]::Round(($currentJob / $totalJobs) * 100)
+                Write-Progress -Activity "Getting job failure information" -Status "Processing failed job $currentJob of $totalJobs for build #$BuildNumber" -PercentComplete $jobProgress -CurrentOperation "Job: $($job.name)"
+                Write-Verbose "Processing failed job: $($job.name) (ID: $($job.jobId))"
+                (Get-TestArtifact -JobId $job.jobid).Content.Failures
+            }
+        } catch {
+            Write-Verbose "Failed to fetch AppVeyor build details for build ${BuildNumber}: $_"
+        }
+
+        Write-Progress -Activity "Get-AppVeyorFailure" -Completed
+        return
+    }
+
+    # Original logic for PR-based build detection
+    if (-not $PullRequest) {
+        Write-Progress -Activity "Get-AppVeyorFailure" -Status "Fetching open pull requests..." -PercentComplete 0
+        Write-Verbose "No pull request numbers specified, getting all open PRs..."
+        $prsJson = gh pr list --state open --json "number,title,headRefName,state,statusCheckRollup"
+        if (-not $prsJson) {
+            Write-Progress -Activity "Get-AppVeyorFailure" -Completed
+            Write-Warning "No open pull requests found"
+            return
+        }
+        $openPRs = $prsJson | ConvertFrom-Json
+        $PullRequest = $openPRs | ForEach-Object { $_.number }
+        Write-Verbose "Found $($PullRequest.Count) open PRs: $($PullRequest -join ',')"
+    }
+
+    $totalPRs = $PullRequest.Count
+    $currentPR = 0
+
+    foreach ($prNumber in $PullRequest) {
+        $currentPR++
+        $prPercentComplete = [math]::Round(($currentPR / $totalPRs) * 100)
+        Write-Progress -Activity "Getting PR build information" -Status "Processing PR #$prNumber ($currentPR of $totalPRs)" -PercentComplete $prPercentComplete
+        Write-Verbose "Fetching AppVeyor build information for PR #$prNumber"
+
+        $checksJson = gh pr checks $prNumber --json "name,state,link" 2>$null
+        if (-not $checksJson) {
+            Write-Verbose "Could not fetch checks for PR #$prNumber"
+            continue
+        }
+
+        $checks = $checksJson | ConvertFrom-Json
+        $appveyorCheck = $checks | Where-Object { $_.name -like "*AppVeyor*" -and $_.state -match "PENDING|FAILURE" }
+
+        if (-not $appveyorCheck) {
+            Write-Verbose "No failing or pending AppVeyor builds found for PR #$prNumber"
+            continue
+        }
+
+        if ($appveyorCheck.link -match '/project/[^/]+/[^/]+/builds/(\d+)') {
+            $buildId = $Matches[1]
+        } else {
+            Write-Verbose "Could not parse AppVeyor build ID from URL: $($appveyorCheck.link)"
+            continue
+        }
+
+        try {
+            Write-Progress -Activity "Getting build details" -Status "Fetching build details for PR #$prNumber" -PercentComplete $prPercentComplete
+            Write-Verbose "Fetching build details for build ID: $buildId"
+
+            $apiParams = @{
+                Endpoint = "projects/dataplat/dbatools/builds/$buildId"
+            }
+            $build = Invoke-AppVeyorApi @apiParams
+
+            if (-not $build -or -not $build.build -or -not $build.build.jobs) {
+                Write-Verbose "No build data or jobs found for build $buildId"
+                continue
+            }
+
+            $failedJobs = $build.build.jobs | Where-Object Status -eq "failed"
+
+            if (-not $failedJobs) {
+                Write-Verbose "No failed jobs found in build $buildId"
+                continue
+            }
+
+            $totalJobs = $failedJobs.Count
+            $currentJob = 0
+
+            foreach ($job in $failedJobs) {
+                $currentJob++
+                Write-Progress -Activity "Getting job failure information" -Status "Processing failed job $currentJob of $totalJobs for PR #$prNumber" -PercentComplete $prPercentComplete -CurrentOperation "Job: $($job.name)"
+                Write-Verbose "Processing failed job: $($job.name) (ID: $($job.jobId))"
+                (Get-TestArtifact -JobId $job.jobid).Content.Failures
+            }
+        } catch {
+            Write-Verbose "Failed to fetch AppVeyor build details for build ${buildId}: $_"
+            continue
+        }
+    }
+
+    Write-Progress -Activity "Get-AppVeyorFailure" -Completed
+}

.aitools/module/Get-TestArtifact.ps1

@@ -0,0 +1,81 @@
+function Get-TestArtifact {
+    <#
+    .SYNOPSIS
+        Gets test artifacts from an AppVeyor job.
+
+    .DESCRIPTION
+        Retrieves test failure summary artifacts from an AppVeyor job.
+
+    .PARAMETER JobId
+        The AppVeyor job ID to get artifacts from.
+
+    .NOTES
+        Tags: AppVeyor, Testing, Artifacts
+        Author: dbatools team
+        Requires: APPVEYOR_API_TOKEN environment variable
+    #>
+    [CmdletBinding()]
+    param(
+        [Parameter(ValueFromPipeline)]
+        [string[]]$JobId
+    )
+
+    function Get-JsonFromContent {
+        param([Parameter(ValueFromPipeline)]$InputObject)
+        process {
+            if ($null -eq $InputObject) { return $null }
+
+            # AppVeyor often returns PSCustomObject with .Content (string) and .Created
+            $raw = if ($InputObject -is [string] -or $InputObject -is [byte[]]) {
+                $InputObject
+            } elseif ($InputObject.PSObject.Properties.Name -contains 'Content') {
+                $InputObject.Content
+            } else {
+                [string]$InputObject
+            }
+
+            $s = if ($raw -is [byte[]]) { [Text.Encoding]::UTF8.GetString($raw) } else { [string]$raw }
+            $s = $s.TrimStart([char]0xFEFF)  # strip BOM
+            if ($s -notmatch '^\s*[\{\[]') {
+                throw "Artifact body is not JSON. Starts with: '$($s.Substring(0,1))'."
+            }
+            $s | ConvertFrom-Json -Depth 50
+        }
+    }
+
+    foreach ($id in $JobId) {
+        Write-Verbose ("Fetching artifacts for job {0}" -f $id)
+        $list = Invoke-AppVeyorApi "buildjobs/$id/artifacts"
+        if (-not $list) { Write-Warning ("No artifacts for job {0}" -f $id); continue }
+
+        $targets = $list | Where-Object { $_.fileName -match 'TestFailureSummary.*\.json' }
+        if (-not $targets) {
+            continue
+        }
+
+        foreach ($art in $targets) {
+            $resp = Invoke-AppVeyorApi "buildjobs/$id/artifacts/$($art.fileName)"
+
+            $parsed = $null
+            $rawOut = $null
+            $created = if ($resp.PSObject.Properties.Name -contains 'Created') { $resp.Created } else { $art.created }
+
+            try {
+                $parsed = $resp | Get-JsonFromContent
+            } catch {
+                $rawOut = if ($resp.PSObject.Properties.Name -contains 'Content') { [string]$resp.Content } else { [string]$resp }
+                Write-Warning ("Failed to parse {0} in job {1}: {2}" -f $art.fileName, $id, $_.Exception.Message)
+            }
+
+            [pscustomobject]@{
+                JobId      = $id
+                FileName   = $art.fileName
+                Type       = $art.type
+                Size       = $art.size
+                Created    = $created
+                Content    = $parsed
+                Raw        = $rawOut
+            }
+        }
+    }
+}