Fixes for a lot of tests that outputed unwanted warnings

tests/Import-DbaCsv.Tests.ps1

@@ -14,135 +14,139 @@ Describe "$CommandName Unit Tests" -Tag 'UnitTests' {
 }
 
 Describe "$CommandName Integration Tests" -Tag "IntegrationTests" {
-    AfterAll {
-        # TODO: WARNING: [12:43:16][Invoke-DbaQuery] [CLIENT\SQLInstance2] Failed during execution | Cannot drop the table 'CommaSeparatedWithHeader', because it does not exist or you do not have permission.
-        Invoke-DbaQuery -SqlInstance $TestConfig.instance1, $TestConfig.instance2 -Database tempdb -Query "drop table SuperSmall; drop table CommaSeparatedWithHeader"
+    BeforeAll {
+        $pathSuperSmall = "$($TestConfig.appveyorlabrepo)\csv\SuperSmall.csv"
+        $pathCommaSeparatedWithHeader = "$($TestConfig.appveyorlabrepo)\csv\CommaSeparatedWithHeader.csv"
+        $pathCols = "$($TestConfig.appveyorlabrepo)\csv\cols.csv"
+        $pathCol2 = "$($TestConfig.appveyorlabrepo)\csv\col2.csv"
+        $pathPipe3 = "$($TestConfig.appveyorlabrepo)\csv\pipe3.psv"
     }
 
-    $path = "$($TestConfig.appveyorlabrepo)\csv\SuperSmall.csv"
-    $CommaSeparatedWithHeader = "$($TestConfig.appveyorlabrepo)\csv\CommaSeparatedWithHeader.csv"
-    $col1 = "$($TestConfig.appveyorlabrepo)\csv\cols.csv"
-    $col2 = "$($TestConfig.appveyorlabrepo)\csv\col2.csv"
-    $pipe3 = "$($TestConfig.appveyorlabrepo)\csv\pipe3.psv"
-
+    AfterAll {
+        Get-DbaDbTable -SqlInstance $TestConfig.instance1, $TestConfig.instance2 -Database tempdb -Table SuperSmall, CommaSeparatedWithHeader | Remove-DbaDbTable -Confirm:$false
+    }
 
     Context "Works as expected" {
-        $results = $path | Import-DbaCsv -SqlInstance $TestConfig.instance1 -Database tempdb -Delimiter `t -NotifyAfter 50000 -WarningVariable warn -WarningAction SilentlyContinue
-        # TODO: Test for "Table or view SuperSmall does not exist and AutoCreateTable was not specified"
         It "accepts piped input and doesn't add rows if the table does not exist" {
-            $results | Should -Be $null
+            $results = $pathSuperSmall | Import-DbaCsv -SqlInstance $TestConfig.instance1 -Database tempdb -Delimiter `t -NotifyAfter 50000 -WarningVariable WarnVar -WarningAction SilentlyContinue
+
+            $WarnVar | Should -BeLike "*Table or view SuperSmall does not exist and AutoCreateTable was not specified*"
+            $results | Should -BeNullOrEmpty
         }
 
         It "creates the right columnmap (#7630), handles pipe delimiters (#7806)" {
-            $null = Import-DbaCsv -SqlInstance $TestConfig.instance1 -Path $col1 -Database tempdb -AutoCreateTable -Table cols
-            $null = Import-DbaCsv -SqlInstance $TestConfig.instance1 -Path $col2 -Database tempdb -Table cols
-            $null = Import-DbaCsv -SqlInstance $TestConfig.instance1 -Path $pipe3 -Database tempdb -Table cols2 -Delimiter "|" -AutoCreateTable
+            $null = Import-DbaCsv -SqlInstance $TestConfig.instance1 -Path $pathCols -Database tempdb -AutoCreateTable -Table cols
+            $null = Import-DbaCsv -SqlInstance $TestConfig.instance1 -Path $pathCol2 -Database tempdb -Table cols
+            $null = Import-DbaCsv -SqlInstance $TestConfig.instance1 -Path $pathPipe3 -Database tempdb -Table cols2 -Delimiter "|" -AutoCreateTable
+
+
             $results = Invoke-DbaQuery -SqlInstance $TestConfig.instance1 -Database tempdb -Query "select * from cols"
+
             $results | Where-Object third -notmatch "three" | Should -BeNullOrEmpty
             $results | Where-Object firstcol -notmatch "one" | Should -BeNullOrEmpty
+
+
             $results = Invoke-DbaQuery -SqlInstance $TestConfig.instance1 -Database tempdb -Query "select * from cols2"
+
             $results | Where-Object third -notmatch "three" | Should -BeNullOrEmpty
             $results | Where-Object firstcol -notmatch "one" | Should -BeNullOrEmpty
         }
 
-        if (-not $env:appveyor) {
-            $results = Import-DbaCsv -Path $path, $path -SqlInstance $TestConfig.instance1, $TestConfig.instance2 -Database tempdb -Delimiter `t -NotifyAfter 50000 -WarningVariable warn2 -AutoCreateTable
-
-            It "performs 4 imports" {
-                ($results).Count | Should -Be 4
-            }
+        It "performs 4 imports" {
+            $results = Import-DbaCsv -Path $pathSuperSmall, $pathSuperSmall -SqlInstance $TestConfig.instance1, $TestConfig.instance2 -Database tempdb -Delimiter `t -NotifyAfter 50000 -WarningVariable warn2 -AutoCreateTable
 
+            ($results).Count | Should -Be 4
             foreach ($result in $results) {
-                It "returns the good stuff" {
-                    $result.RowsCopied | Should -Be 999
-                    $result.Database | Should -Be tempdb
-                    $result.Table | Should -Be SuperSmall
-                }
-            }
-
-            $result = Import-DbaCsv -Path $path -SqlInstance $TestConfig.instance1 -Database tempdb -Delimiter `t -Table SuperSmall -Truncate
-            It "doesn't break when truncate is passed" {
                 $result.RowsCopied | Should -Be 999
                 $result.Database | Should -Be tempdb
                 $result.Table | Should -Be SuperSmall
             }
+        }
 
-            $result = Import-DbaCsv -Path $path -SqlInstance $TestConfig.instance1 -Database tempdb -Delimiter `t -Table SuperSmall -Truncate -NoTransaction
-            It "works with NoTransaction" {
-                $result.RowsCopied | Should -Be 999
-                $result.Database | Should -Be tempdb
-                $result.Table | Should -Be SuperSmall
-            }
+        It "doesn't break when truncate is passed" {
+            $result = Import-DbaCsv -Path $pathSuperSmall -SqlInstance $TestConfig.instance1 -Database tempdb -Delimiter `t -Table SuperSmall -Truncate
+
+            $result.RowsCopied | Should -Be 999
+            $result.Database | Should -Be tempdb
+            $result.Table | Should -Be SuperSmall
+        }
+
+        It "works with NoTransaction" {
+            $result = Import-DbaCsv -Path $pathSuperSmall -SqlInstance $TestConfig.instance1 -Database tempdb -Delimiter `t -Table SuperSmall -Truncate -NoTransaction
+
+            $result.RowsCopied | Should -Be 999
+            $result.Database | Should -Be tempdb
+            $result.Table | Should -Be SuperSmall
         }
 
         It "Catches the scenario where the database param does not match the server object passed into the command" {
-            $server = Connect-DbaInstance $TestConfig.instance1 -Database tempdb
-            $result = Import-DbaCsv -Path $path -SqlInstance $server -Database InvalidDB -Delimiter `t -Table SuperSmall -Truncate -AutoCreateTable -WarningAction SilentlyContinue
-            # TODO: test for Cannot open database "InvalidDB" requested by the login. The login failed.
+            $result = Import-DbaCsv -Path $pathSuperSmall -SqlInstance $TestConfig.instance1 -Database InvalidDB -Delimiter `t -Table SuperSmall -Truncate -AutoCreateTable -WarningVariable WarnVar  -WarningAction SilentlyContinue
+
+            $WarnVar | Should -BeLike "*Cannot open database * requested by the login. The login failed.*"
             $result | Should -BeNullOrEmpty
 
-            $server = Connect-DbaInstance $TestConfig.instance1 -Database tempdb
-            $result = Import-DbaCsv -Path $path -SqlInstance $server -Database tempdb -Delimiter `t -Table SuperSmall -Truncate -AutoCreateTable
+            $result = Import-DbaCsv -Path $pathSuperSmall -SqlInstance $TestConfig.instance1 -Database tempdb -Delimiter `t -Table SuperSmall -Truncate -AutoCreateTable
+
             $result.RowsCopied | Should -Be 999
             $result.Database | Should -Be tempdb
             $result.Table | Should -Be SuperSmall
         }
 
         It "Catches the scenario where the header is not properly parsed causing param errors" {
-            # TODO: WARNING: [12:43:13][Invoke-DbaQuery] [CLIENT] Failed during execution | Cannot drop the table 'NoHeaderRow', because it does not exist or you do not have permission.
-            # TODO: What line writes the warning? Is this correct?
-
             # create the table using AutoCreate
-            $server = Connect-DbaInstance $TestConfig.instance1 -Database tempdb
-            $null = Import-DbaCsv -Path $CommaSeparatedWithHeader -SqlInstance $server -Database tempdb -AutoCreateTable
-
+            $null = Import-DbaCsv -Path $pathCommaSeparatedWithHeader -SqlInstance $TestConfig.instance1 -Database tempdb -AutoCreateTable
             # reload table without AutoCreate parameter to recreate bug #6553
-            $result = Import-DbaCsv -Path $CommaSeparatedWithHeader -SqlInstance $server -Database tempdb -Truncate
+            $result = Import-DbaCsv -Path $pathCommaSeparatedWithHeader -SqlInstance $TestConfig.instance1 -Database tempdb -Truncate
+
             $result.RowsCopied | Should -Be 1
             $result.Database | Should -Be tempdb
             $result.Table | Should -Be CommaSeparatedWithHeader
-            Invoke-DbaQuery -SqlInstance $server -Query 'DROP TABLE NoHeaderRow'
+
+            Invoke-DbaQuery -SqlInstance $TestConfig.instance1 -Database tempdb -Query 'DROP TABLE CommaSeparatedWithHeader'
         }
 
         It "works with NoHeaderRow" {
             # See #7759
             $server = Connect-DbaInstance $TestConfig.instance1 -Database tempdb
             Invoke-DbaQuery -SqlInstance $server -Query 'CREATE TABLE NoHeaderRow (c1 VARCHAR(50), c2 VARCHAR(50), c3 VARCHAR(50))'
-            $result = Import-DbaCsv -Path $col1 -NoHeaderRow -SqlInstance $server -Database tempdb -Table 'NoHeaderRow' -WarningVariable warnNoHeaderRow
+
+            $result = Import-DbaCsv -Path $pathCols -NoHeaderRow -SqlInstance $server -Database tempdb -Table 'NoHeaderRow'
             $data = Invoke-DbaQuery -SqlInstance $server -Query 'SELECT * FROM NoHeaderRow' -As PSObject
-            Invoke-DbaQuery -SqlInstance $server -Query 'DROP TABLE NoHeaderRow'
 
-            $warnNoHeaderRow | Should -BeNullOrEmpty
-            $result | Should -Not -BeNullOrEmpty
             $result.RowsCopied | Should -Be 3
             $data[0].c1 | Should -Be 'firstcol'
+
+            Invoke-DbaQuery -SqlInstance $server -Query 'DROP TABLE NoHeaderRow'
         }
 
         It "works with tables which have non-varchar types (date)" {
             # See #9433
             $server = Connect-DbaInstance $TestConfig.instance1 -Database tempdb
             Invoke-DbaQuery -SqlInstance $server -Query 'CREATE TABLE WithTypes ([date] DATE, col1 VARCHAR(50), col2 VARCHAR(50))'
-            $result = Import-DbaCsv -Path $CommaSeparatedWithHeader -SqlInstance $server -Database tempdb -Table 'WithTypes'
-            Invoke-DbaQuery -SqlInstance $server -Query 'DROP TABLE WithTypes'
+            $result = Import-DbaCsv -Path $pathCommaSeparatedWithHeader -SqlInstance $server -Database tempdb -Table 'WithTypes'
 
             $result | Should -Not -BeNullOrEmpty
             $result.RowsCopied | Should -Be 1
+
+            Invoke-DbaQuery -SqlInstance $server -Query 'DROP TABLE WithTypes'
         }
 
         It "works with tables which have non-varchar types (guid, bit)" {
             # See #9433
-            $filePath = '.\foo.csv'
+            $filePath = "$($TestConfig.Temp)\foo.csv"
             $server = Connect-DbaInstance $TestConfig.instance1 -Database tempdb
             Invoke-DbaQuery -SqlInstance $server -Query 'CREATE TABLE WithGuidsAndBits (one_guid UNIQUEIDENTIFIER, one_bit BIT)'
             $row = [pscustomobject]@{
                 one_guid = (New-Guid).Guid
                 one_bit  = 1
             }
             $row | Export-Csv -Path $filePath -NoTypeInformation
+
             $result = Import-DbaCsv -Path $filePath -SqlInstance $server -Database tempdb -Table 'WithGuidsAndBits'
-            Invoke-DbaQuery -SqlInstance $server -Query 'DROP TABLE WithGuidsAndBits'
 
             $result.RowsCopied | Should -Be 1
+
+            Invoke-DbaQuery -SqlInstance $server -Query 'DROP TABLE WithGuidsAndBits'
             Remove-Item $filePath
         }
     }

tests/Install-DbaMaintenanceSolution.Tests.ps1

@@ -24,12 +24,12 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
             Invoke-DbaQuery -SqlInstance $TestConfig.instance3 -Database tempdb -Query "drop procedure CommandExecute; drop procedure DatabaseBackup; drop procedure DatabaseIntegrityCheck; drop procedure IndexOptimize;"
         }
         It "does not overwrite existing " {
-            $results = Install-DbaMaintenanceSolution -SqlInstance $TestConfig.instance2 -Database tempdb -WarningVariable warn -WarningAction SilentlyContinue
-            $warn -match "already exists" | Should Be $true
+            $results = Install-DbaMaintenanceSolution -SqlInstance $TestConfig.instance2 -Database tempdb -WarningVariable WarnVar -WarningAction SilentlyContinue
+            $WarnVar  | Should -Match "already exists"
         }
 
         It "Continues the installation on other servers " {
-            $results2 = Install-DbaMaintenanceSolution -SqlInstance $TestConfig.instance2, $TestConfig.instance3 -Database tempdb
+            $results2 = Install-DbaMaintenanceSolution -SqlInstance $TestConfig.instance2, $TestConfig.instance3 -Database tempdb -WarningAction SilentlyContinue
             $sproc = Get-DbaDbModule -SqlInstance $TestConfig.instance3 -Database tempdb | Where-Object { $_.Name -eq "CommandExecute" }
             $sproc | Should -Not -BeNullOrEmpty
         }

tests/Install-DbaMultiTool.Tests.ps1

@@ -17,8 +17,7 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
         BeforeAll {
             $branch = "main"
             $database = "dbatoolsci_multitool_$(Get-Random)"
-            $server = Connect-DbaInstance -SqlInstance $TestConfig.instance2
-            $server.Query("CREATE DATABASE $database")
+            $null = New-DbaDatabase -SqlInstance $TestConfig.instance2 -Name $database
 
             $resultsDownload = Install-DbaMultiTool -SqlInstance $TestConfig.instance2 -Database $database -Branch $branch -Force -Verbose:$false
         }
@@ -48,7 +47,7 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
             $folder = Join-Path (Get-DbatoolsConfigValue -FullName Path.DbatoolsData) -Child "dba-multitool-$branch"
             $sqlScript = Get-ChildItem $folder -Filter "sp_*.sql" | Select-Object -First 1
             Add-Content $sqlScript.FullName (New-Guid).ToString()
-            $result = Install-DbaMultiTool -SqlInstance $TestConfig.instance2 -Database $database -Verbose:$false
+            $result = Install-DbaMultiTool -SqlInstance $TestConfig.instance2 -Database $database -Verbose:$false -WarningAction SilentlyContinue
             $result = $result | Where-Object Name -eq $sqlScript.BaseName
             $result.Status -eq "Error" | Should -Be $true
         }
@@ -93,7 +92,7 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
             $folder = Join-Path (Get-DbatoolsConfigValue -FullName Path.DbatoolsData) -Child "dba-multitool-$branch"
             $sqlScript = Get-ChildItem $folder -Filter "sp_*.sql" | Select-Object -First 1
             Add-Content $sqlScript.FullName (New-Guid).ToString()
-            $result = Install-DbaMultiTool -SqlInstance $TestConfig.instance3 -Database $database -Verbose:$false
+            $result = Install-DbaMultiTool -SqlInstance $TestConfig.instance3 -Database $database -Verbose:$false -WarningAction SilentlyContinue
             $result = $result | Where-Object Name -eq $sqlScript.BaseName
             $result.Status -eq "Error" | Should -Be $true
         }