fix broken connections in case of high latency #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 56.38% 56.35% -0.04%
==========================================
Files 22 22
Lines 4182 4181 -1
==========================================
- Hits 2358 2356 -2
Misses 1510 1510
- Partials 314 315 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aler9
force-pushed
the
patch-duplicate-conns
branch
5 times, most recently
from
bff3314 to
0ae3f38
Compare
13 tasks
aler9
force-pushed
the
patch-duplicate-conns
branch
from
0ae3f38 to
c99e7d2
Compare
When listening and accepting an incoming connection request, the response might be received by the peer with some delay due to latency. This causes the peer to send a second connection request, that is not detected as duplicate because the first connection request has already been removed from the map that is used to check for duplicates (connReqs), so it is treated as a brand new connection request, breaking the first connection. This patch fixes the issue by replacing the map that is used to check for duplicates (connReqs) with a map that keeps track of both connection requests and accepted connections by their peer ID (connByPeers), allowing to discard handshakes with an existing peer ID.
aler9
force-pushed
the
patch-duplicate-conns
branch
from
c99e7d2 to
d7fe54d
Compare
|
Very important fix. Thanks, @aler9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: bluenviron/mediamtx#3756
When listening and accepting an incoming connection request, the response might be received by the peer with some delay due to latency. This causes the peer to send a second connection request, that is not detected as duplicate because the first connection request has already been removed from the map that is used to check for duplicates
(connReqs), so it is treated as a brand new connection request, breaking the first connection.
This patch fixes the issue by introducing another map (connByPeer) that is used to check whether a connection request is associated to an already-accepted connection.