Fatping #12
Closed
Fatping #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icing with value "Parameter"
…alidTaskPing actually valid again
…ork speed + unit elements and the way they are used in the ping status extension defines if they are to be interpreted as download or upload speeds
…twork speed extension before ping status extension as ping status extension references network speed extension which needs to be loaded before ping status extension gets loaded
… pong-send to pong-sent
…rk-speed-extension's Extension.extension:network-speed.url element in ConstantsPing
…ompatibility to older plugin versions
…d automatically. Instead, the entire requested content size should be generated. When downloading, only the content gets downloaded which also is already decoded. Set the execution variable "downloadResourceSizeBytes" to the size that was generated just to be safe.
… because the optionals were empty
…sulting in a second, incomplete output to be generated
…IR server. This also required adding a new error-message output element to task-start-ping, modelling new BPMN errors and rewriting a lot of code to make able to handle things that were not considered to be missable so far
…on and didn't carry any message, the error message in the status output would read something along the lines of "Error message empty" because there wasn't any message provided to the BPMN error that is thrown if downloadResult contains an error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final PR for Fat-Ping. Currently in state RC1. Can be merged if RC1 is good enough for actual release. Documentation can be found in wiki. Feature changes in RC1 release notes.