Issue/11 fat ping #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name. This should fix camunda db error complaining that the variable was modified concurrently by another transaction
…n empty stream as the execution variables are only populated when a download took place
…orm why there is a difference between requested and generated size
…p() which also reads the data from the InputStream but does so in 2024 byte chunks which does not run into the risk of running out of memory. Also improved formatting of download time
…y overwriting sendTask is CleanupPong
…Pong is not a Message End Event anymore. This was a copy-paste error
… with other generators
…tion should not be implementable
… pong message like failing to download the resource from the ping instance
…ABLE_ERROR_MESSAGE is now only possible via getters. They also come overloaded with a correlation key parameter to make addressing versions of the execution variables in parallel processes consistent
…S_CODE and BPMN_EXECUTION_VARIABLE_ERROR_MESSAGE constants with getters
…_VARIABLE_DOWNLOADED_DURATION_MILLIS is now only possible via getters. They also come overloaded with a correlation key parameter to make addressing versions of the execution variables in parallel processes consistent
…gs this information
…might reduce errors given that the error list will be modified concurrently
…e element making it so the new extension only adds to the previous version
…ing for every type of error. Also removed exception messages from errors to prevent leaking any potentially critical information
- Added resource version to PingProcessPluginDefinition - CodeSystems now include a method that returns a Coding based on a provided Code which always includes the resource version from the PingProcessPluginDefinition - Refactored uses of new Coding initialization to use the methods provided by the respective CodeSystem instead
… errors need to be communicated remotely after failing to send the pong message in the pong process
- The CodeSystem dsf-ping-status now contains the codes from version 1.0 of the plugin again, meaning the old semantics of the ping and pong status fields have been restored. HTTP status codes 401 and 403 have been mapped to code "not-allowed." All other types or errors are mapped to "not-reachable" as its description was the most fitting target for a catch-all rule for failed requests. Exact error codes with potential fix URLs are still listed in the extension
…end of display values
…d of HTTP fix URL
- Added handling for possible HttpHostConnectException and ConnectTimeoutExceptions when making requests concerning non-Task resources - Specified unknown errors to either originate from the local or remote instance
…stems and Ping-Status-Extension of old PingPong versions to match the new version. This required making those resources backwards compatible, meaning the new version of the resources has its elements declared as optional in such a way that it is possible to construct both a valid resource for older plugin versions and new plugin versions - Removed "-v2" suffixes from all resources as this is no longer required to work around versioning issues. Removed the v1 extension in test resources, because it will now break tests, since PingPongProcessPluginDeploymentStateListener is not fixing resources in test cases - Amended versions to Codings that were overseen in 330cce9 - Enforced usage of versions for ping pong plugin Codings in StructureDefinitions for Task resources. Going forward, this prevents the issue where Task resources are unable to be posted because codes are searched for in the wrong CodeSystem version
…status-extension.errors
…resulted in logs being polluted with warnings because there is an extension on a resource with neither a value nor other extensions present
… not that a timer event triggered in the BPMN but that an expected message is missing
… to upload-speed-to-remote to reduce ambiguity as the values could previously be interpreted as the network speed to and from the local FHIR server
… value in a given prefix exceed 1000. This is now the default configuration for network speeds which can still be overridden.
…en trying to download a resource and the resulting error prevented any bytes from being downloaded
…use that is about the largest amount of data that can be stored in a Binary resource in DSF 1.x.
…ccur if the DEV_DSF_BPE_FHIR_CLIENT_REMOTE_TIMEOUT_READ is too short
…ration the process waits for pong messages to allow adjusting for different network throughputs and hardware environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11