Issue/11 fat ping #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ABLE_ERROR_MESSAGE is now only possible via getters. They also come overloaded with a correlation key parameter to make addressing versions of the execution variables in parallel processes consistent
…S_CODE and BPMN_EXECUTION_VARIABLE_ERROR_MESSAGE constants with getters
…_VARIABLE_DOWNLOADED_DURATION_MILLIS is now only possible via getters. They also come overloaded with a correlation key parameter to make addressing versions of the execution variables in parallel processes consistent
…gs this information
…might reduce errors given that the error list will be modified concurrently
… and maxUploadSizeBytes
… SaveDownloadSpeeds is called in Ping process
…fileTest to use BigDecimal instead of integer for download speeds as this was intended by the FHIR resources in the first place
…vironment variable and removed the service delegate LogSendError which was forgotten in a previous commit
…. Added missing upload versions of the network transfer information
…o validate its value. Also changed SaveDownloadSpeeds to SaveDownloadSpeedsPing which was renamed in a previous commit
…ot stored if cleanup pong got received or timed out. This did not cover the case where pong is able to download a resource from ping but Send Pong runs e.g. into a network error. In this case, the download speed of the download from ping should still be stored.
…ecause actual download speeds get saved by "Download Resource and Measure Speed". Also added a service delegate for "Save Upload Speeds"
…oad Resource And Measure Speed"
…ntermediateThrowEventError()
…download speeds might have to be saved
…use that is about the largest amount of data that can be stored in a Binary resource in DSF 1.x.
…ccur if the DEV_DSF_BPE_FHIR_CLIENT_REMOTE_TIMEOUT_READ is too short
…ration the process waits for pong messages to allow adjusting for different network throughputs and hardware environments
…uested if maximum upload resource size was negative
…ght occur which would cause the process to fail and leave any generated Binary resources on the FHIR server. BPMN errors then cause the process to skip to the CleanUp service task to delete the Binary resource before completing the process. This required changing the way ping statuses are being generated as they assumed that certain information would be present when generated, which might not be the case anymore
…tead of actually downloaded bytes which caused wrong download speeds to be calculated
…e. Slim-ping should only get executed if download size from Task input parameter is negative
…error is known by looking in the logs but it is indeed unexpected
hhund
requested changes
Oct 18, 2025
Member
hhund
left a comment
hhund
left a comment
There was a problem hiding this comment.
Some ValueSet bindings are specified without version, please fix to allow parallel execution of versions 1.0 and 2.0.
src/main/resources/fhir/StructureDefinition/dsf-task-cleanup-pong.xml
Outdated
Show resolved
Hide resolved
src/main/resources/fhir/StructureDefinition/dsf-task-cleanup-pong.xml
Outdated
Show resolved
Hide resolved
…of ValueSets are not referenced by accident if both v1 and v2 versions of ping pong are deployed.
hhund
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11