Issue cleanup round #1

[a-random-steve]

(for perusal, will likely replace this PR once we merge in the others)

Fixes the following issues

• Resolves waitForDb in create/drop database should not be an optional parameter #90
• Resolves Absence of a [CollectionName] attribute? #76
• Resolves Incomplete FilterModelStatus for querying reranking/embedding providers? #77
• Resolves Relation between TableFilterBuilder, FilterBuilder and PrimaryKeyFilter ? #75
• Resolves Nan, Infinity and -Infinity not recognized when reading floats/doubles #65
• Resolves TimeoutOptions duplicates some of the fields found in TimeoutDefaults? #72
• Resolves timeuuids should live in their own dedicated TimeUuid class #50
• Resolves Lots of relatively-irrelevant warnings potentially masking importing warnings #51

[skedwards88]

I'm adding this to the docs, but unlike GetTable which has an overload public Table<TRow> GetTable<TRow>() where TRow : class, new();, GetCollection always requires a collection name even if you pass it the document type with the CollectionName attribute.

[a-random-steve]

@skedwards88 Good call. I have added the additional overloads that allow GetCollection() or GetCollection<T,TId>()

[skedwards88]

Can you double check this works? I get this when I try:

Unhandled exception. System.ArgumentNullException: collectionName (Parameter 'Value cannot be null or empty.')
   at DataStax.AstraDB.DataApi.Utils.Guard.NotNullOrEmpty(String value, String paramName, String message) in /Users/sarah.edwards/repos/astra-db-csharp/src/DataStax.AstraDB.DataApi/Utils/Guard.cs:line 29
   at DataStax.AstraDB.DataApi.Core.Database.GetCollection[T](String collectionName, DatabaseCollectionCommandOptions options) in /Users/sarah.edwards/repos/astra-db-csharp/src/DataStax.AstraDB.DataApi/Core/Database.cs:line 669
   at DataStax.AstraDB.DataApi.Core.Database.GetCollection[T]() in /Users/sarah.edwards/repos/astra-db-csharp/src/DataStax.AstraDB.DataApi/Core/Database.cs:line 654
   at Examples.Example.Main() in /Users/sarah.edwards/repos/astra-client-docs-tests/.docs_tests_temp/execution_environments/csharp/Example.cs:line 47
   at Examples.Example.<Main>()

from running

using DataStax.AstraDB.DataApi;
using DataStax.AstraDB.DataApi.Collections;
using DataStax.AstraDB.DataApi.Core;
using DataStax.AstraDB.DataApi.SerDes;

namespace Examples;

[CollectionName("**COLLECTION_NAME**")]
public class ExampleDocument
{
  [DocumentId]
  public Guid? Id { get; set; }

  [DocumentMapping(DocumentMappingField.Vector)]
  public float[]? VectorEmbeddings { get; set; }

  [DocumentMapping(DocumentMappingField.Vectorize)]
  public string? StringToVectorize { get; set; }

  [DocumentMapping(DocumentMappingField.Lexical)]
  [LexicalOptions(
    TokenizerName = "standard",
    Filters = new[] { "lowercase" }
  )]
  public string? StringForLexical { get; set; }

  // [DocumentMapping(DocumentMappingField.Similarity)]
  // public double Similarity { get; set; }

  public string? Title { get; set; }

  public int? NumberOfPages { get; set; }

  public bool? IsCheckedOut { get; set; }
}

public class Program
{
  static async Task Main()
  {
    // Get an existing collection
    var client = new DataAPIClient();
    var database = client.GetDatabase(
      "**API_ENDPOINT**",
      "**APPLICATION_TOKEN**"
    );
    var collection = database.GetCollection<ExampleDocument>();

    // Insert documents
    var insertionResult = await collection.InsertManyAsync(
      [
        new ExampleDocument()
        {
          VectorEmbeddings = [0.08f, -0.62f, 0.39f],
          Title = "Ocean Depths",
          NumberOfPages = 434,
          IsCheckedOut = false,
        },
        new ExampleDocument()
        {
          StringToVectorize =
            "A thrilling novel about the future of flight.",
          Title = "Sky Limits",
          NumberOfPages = 298,
        },
        new ExampleDocument()
        {
          Id = Guid.CreateVersion7(),
          Title = "Open Plains",
          IsCheckedOut = true,
        },
      ]
    );

    // Find documents
    var filterBuilder = Builders<ExampleDocument>.Filter;
    var filter = filterBuilder.And(
      filterBuilder.Eq(x => x.IsCheckedOut, false),
      filterBuilder.Lt(x => x.NumberOfPages, 300)
    );
    var findResult = collection
      .Find(filter)
      .Project(
        Builders<ExampleDocument>
          .Projection.Include(x => x.Title)
          .Include(x => x.IsCheckedOut)
      );

    await foreach (var document in findResult)
    {
      Console.WriteLine(
        System.Text.Json.JsonSerializer.Serialize(document)
      );
    }
  }
}

[skedwards88]

(but that error goes away if I call GetCollection with the collection name)

[a-random-steve]

@skedwards88 did you get that error running against this branch? Will make sure there's a working test for that overload.

[skedwards88]

Yes, I verified just now that I am up to date and retested but get the same error

[a-random-steve]

@skedwards88 Found the missing piece and updated. Good catch!

[skedwards88]

I don't know if this is intentional or not: I get a Argument 1: cannot convert from 'DataStax.AstraDB.DataApi.Core.Query.CollectionFilter<DataStax.AstraDB.DataApi.Tables.Row>' to 'DataStax.AstraDB.DataApi.Core.Query.TableFilter<DataStax.AstraDB.DataApi.Tables.Row>' error if I do Builders<Row>.Filter. Did you mean to make Filter fall back to CollectionFilter, or did you intend to force the user to specify CollectionFilter?

[a-random-steve]

@skedwards88 Fixed, Filter was intended to be removed.

[skedwards88]

It looks like #90 also covers DropDatabase(Async), but I only see changes for CreateDatabase(Async)

[a-random-steve]

Fixed, and rearranged the params per #90.

[skedwards88]

@a-random-steve it looks like you missed the overload for DropDatabaseAsync that doesn't require waitForDb (but you have it for DropDatabase)

[a-random-steve]

Updated...I think I have all the potentials covered now!

[sl-at-ibm]

Wow, that's a lot of stuff indeed! I left some comments and suggestions on the code.

A general point to address: when I run the IT locally (on HCD) I get two failures:

[xUnit.net 00:00:13.40]     DataStax.AstraDB.DataApi.IntegrationTests.UserDefinedTypesTests.UserDefinedTypes_CreateFromClasses [FAIL]
  Error Message:
   System.Text.Json.JsonException : The JSON value could not be converted to System.TimeOnly. Path: $.Time | LineNumber: 0 | BytePositionInLine: 116.

[xUnit.net 00:18:39.51]     DataStax.AstraDB.DataApi.IntegrationTests.SerializationTests.TestSpecific [FAIL]
  Error Message:
   System.Text.Json.JsonException : Unexpected token String when reading date value.

Can you confirm?