-
Notifications
You must be signed in to change notification settings - Fork 27
Migrate from legacy config classes #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from legacy config classes #247
Conversation
* Upgrade Quarkus to 3.25.0 * Updates to make the project buildable with JDK 21 * Migrate from legacy config classes to @ConfigMapping interfaces Fixes datastax#246
5ebd8fd
to
c6eab1f
Compare
👋 for your information, this is going to be blocking for the upcoming Quarkus 3.26.0 coming in August. I might also have some other things to fix in this component before the release so it would be nice if this could be merged once CI has run so that we can make progress on the other issues. Thanks! |
Thanks for the PR @jamesnetherton! This is something I've wanted to get to for some time but work on this extension has been de-prioritized on our end... so it's been difficult to find time for it. I'm working on running this through some tests on our side. Assuming there aren't any problems (and I'm not expecting any) I'll try to get this merged shortly so as to unblock any future work (per the comments above from @gsmet). |
I've confirmed that I can get the Java test target (as defined in the Jenkinsfile) to pass locally with some very minor tweaks. I haven't been able to get the native integration tests working yet, though. The relevant command there (also defined in the Jenkinsfile) seems to fail consistently in the MicroProfile tests:
As I understand this new build process everything here is happening in the builder Docker image so my working assumption is that anything setup on my local environment won't figure into this. I'll continue digging into this on my end but wanted to get results out here as quickly as possible. |
I originally tested on MacOS with a local GraalVM install and all tests passed there. I just tested on Linux, building the native image in a container and it failed initially at But, I ran the build a second time and it passed without issues 🙃. I'm not sure what's going on TBH. |
So I'm running my tests on Debian 12.5 using the native image builder Docker image. I do see several tests succeed before this one fails; "IT::Main Tests" appears to successfully build a native binary using the image and all the tests therein pass. The next subproject after that is the Microprofile tests and that's when things seem to go off the rails. Is there a flag I can pass to Maven to make it use a local GraalVM instance? I'd kinda like to try this with a local build, see if I get different results. That stack trace is... weird. :( |
See the docs here: https://quarkus.io/guides/building-native-image#configuring-graalvm |
A local test build with graalvm-jdk-21.0.8+12.1 worked fine out of the box. I'll update the Jenkins runner and re-test, but based on these results I think we'll be good to go. |
Jenkins build with local GraalVM install + minor build fixes was green. I'm going to merge this and create a PR for the build fixes and then merge that immediately after. |
Fixes #246