Skip to content

[POC] Reader: customize replica plan iterator for topk #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[POC] Reader: customize replica plan iterator for topk #1674

wants to merge 1 commit into from

Conversation

jasonstack
Copy link

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@jasonstack jasonstack changed the title CNDB-poc-reader: customize replica plan iterator for topk [POC] Reader: customize replica plan iterator for topk Apr 4, 2025
eolivelli
eolivelli reviewed Apr 9, 2025
View reviewed changes
Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

great idea to customize this part instead of changing the rest of TokenMetadata management!

@jasonstack jasonstack force-pushed the cndb-poc-reader branch 2 times, most recently from f6eef2d to 461d374 Compare May 5, 2025 05:58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1674 rejected by Butler

1 new test failure(s) in 4 builds
See build details here

Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔵🔵🔵 🔵🔵🔵🔵🔵🔵🔵

Found 4 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonstack @cassci-bot @eolivelli