Skip to content

CNDB-14261: Separate timeout for aggregation queries (#1741) #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: cndb-main-release-202501
Choose a base branch
from

Conversation

jakubzytka
Copy link

What is the issue

In CC, aggregate user queries use the same range read timeout. In DSE,
we had a separate timeout that defaulted to 120s. We would like to
retain that functionality.
In addition, aggregate queries in metrics look just like range reads.
We'd like to distinguish them.

What does this PR fix and why was it fixed

This PR adds a separate 120s timeout for aggregate queries. The timeout
is configurable with aggregation_request_timeout_in_ms Config
parameter

What is the issue

...

What does this PR fix and why was it fixed

...

@eolivelli
Copy link

https://github.com/riptano/cndb/13770 does not exist

CNDB-13770 is Separate timeout for aggregation queries (#1741)

In CC, aggregate user queries use the same range read timeout. In DSE,
we had a separate timeout that defaulted to 120s. We would like to
retain that functionality.
In addition, aggregate queries in metrics look just like range reads.
We'd like to distinguish them.

This PR adds a separate 120s timeout for aggregate queries. The timeout
is configurable with `aggregation_request_timeout_in_ms` Config
parameter
@jakubzytka jakubzytka force-pushed the cndb-main-release-202501-cndb-13770-hotfix branch from 137fdcc to 8731204 Compare May 28, 2025 13:16
@jakubzytka jakubzytka changed the title CNDB-13770: Separate timeout for aggregation queries (#1741) CNDB-14261: Separate timeout for aggregation queries (#1741) May 28, 2025
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1775 rejected by Butler


5 new test failure(s) in 3 builds
See build details here


Found 5 new test failures

Test Explanation Branch history Upstream history
r.TestReplaceAddress.test_revive_endpoint regression 🔴🔴🔴
...gLegacyIndex.test_sstableloader_with_failing_2i regression 🔴🔴🔴
...t.testKDTreePostingsQueryMetricsWithSingleIndex regression 🔴🔴🔴
o.a.c.i.s.m.MetadataCollectorTest.testNoOverflow regression 🔴🔴🔴
o.a.c.n.ConnectionTest.testTimeout regression 🔴🔵🔵

Found 7 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants