CNDB-14343: Fix ANN queries on primary key and static columns #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
adelapena
force-pushed
the
CNDB-14343-main
branch
from
15ab387 to
43e710d
Compare
Comment on lines
70
to
69
| if (!column.isRegular()) | ||
| return true; |
There was a problem hiding this comment.
I think this is only correct for Primary Key columns since those cannot be updated to a new value. Static columns can be updated and that means we need to validate their source ss/mem table.
There was a problem hiding this comment.
I have added a tiny test case for updating a static column similar to that of VectorUpdateDeleteTest.testUpdateVectorToWorseAndBetterPositions. It seems to work, but it probably needs more testing.
adelapena
force-pushed
the
CNDB-14343-main
branch
from
43e710d to
036f1bc
Compare
adelapena
force-pushed
the
CNDB-14343-main
branch
from
036f1bc to
4fa17fb
Compare
adelapena
force-pushed
the
CNDB-14343-main
branch
from
924d122 to
251c318
Compare
adelapena
force-pushed
the
CNDB-14343-main
branch
from
eac82ce to
b90cace
Compare
|
✔️ Build ds-cassandra-pr-gate/PR-1800 approved by ButlerApproved by Butler |
adelapena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can create a vector index on primary key components and static columns and query an empty table. Still, if an ANN query finds any data, we get an unmanaged replica-side error saying that only regular columns are supported.
For now, I'm just adding some reproduction tests here.