CNDB-9697: notify JVMStabilityInspector when encountered corruption exception on compaction task #1901
+195
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
eolivelli
requested changes
Jul 22, 2025
src/java/org/apache/cassandra/db/compaction/BackgroundCompactionRunner.java
Outdated
Show resolved
Hide resolved
jasonstack
force-pushed
the
cndb-9697-main
branch
from
4ba0ac5 to
616aa0d
Compare
sbtourist
reviewed
Jul 23, 2025
| @@ -460,6 +463,7 @@ public static void handleCompactionError(Throwable t, ColumnFamilyStore cfs) | |||
| // we might have to rely on error message parsing... | |||
| t = t instanceof FSError ? t : new FSWriteError(t); | |||
| JVMStabilityInspector.inspectThrowable(t); | |||
| CompactionManager.instance.incrementAborted(); | |||
There was a problem hiding this comment.
I'm not sure why isn't this incrementFailed();?
There was a problem hiding this comment.
you are right. it should be failed
sbtourist
approved these changes
Jul 29, 2025
|
✔️ Build ds-cassandra-pr-gate/PR-1901 approved by ButlerApproved by Butler |
eolivelli
approved these changes
Jul 30, 2025
sbtourist
approved these changes
Jul 30, 2025
jasonstack
force-pushed
the
cndb-9697-main
branch
from
7d29773 to
72deaca
Compare
jasonstack
force-pushed
the
cndb-9697-main
branch
from
72deaca to
f9bfcf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Corruption excetion from compaction task didn't notify error handler.
Compaction aborted/failed metrics were not updated in some cases.
What does this PR fix and why was it fixed
Trigger JVMStabilityInspector for corruption exception from compaction task and update aborted/failed metircs properly.
Trigger JVMStabilityInspecto for error from repair validation.