Skip to content

CC5 fix AlterTest #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

CC5 fix AlterTest #1921

merged 1 commit into from
Jul 28, 2025

Conversation

djatnieks
Copy link

What is the issue

Fixes https://github.com/riptano/cndb/issues/14954

What does this PR fix and why was it fixed

Fixes CC5 test failure by removing an assert that was likely due to a rebase mistake.

        assertThat(AbstractShardedMemtable.getDefaultShardCount()).isEqualTo(1);;

The assert comes from a CC ticket, STAR-840, but this assert does not appear on main branch in AlterTest. In fact AbstractShardedMemtable is a CC 5.0 only class.
Without digging more into the history of how/why this got added ... it's not needed here since the main branch version does not have any similar check.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks djatnieks requested a review from driftx July 25, 2025 23:59
Copy link

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1921 approved by Butler


Approved by Butler
See build details here

@djatnieks djatnieks merged commit 3e670ec into main-5.0 Jul 28, 2025
573 of 584 checks passed
@djatnieks djatnieks deleted the CNDB-14954 branch July 28, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants