Skip to content

CNDB 15032 SequentialWriter should open a write-only channel by default #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

CNDB 15032 SequentialWriter should open a write-only channel by default #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2176f3
remove unused import
driftx Jul 31, 2025
0feb87f
CNDB-15032: set SequentialWriter channel to write-only by default
driftx Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/java/org/apache/cassandra/io/util/SequentialWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,6 @@ protected Throwable doAbort(Throwable accumulate)
}

// TODO: we should specify as a parameter if we permit an existing file or not
private static FileChannel openChannel(File file)
{
return openChannel(file, true);
}

private static FileChannel openChannel(File file, boolean readable)
{
try
Expand Down Expand Up @@ -171,7 +166,7 @@ public SequentialWriter(File file, SequentialWriterOption option)
*/
public SequentialWriter(File file, SequentialWriterOption option, boolean strictFlushing)
{
this(file, true, option, strictFlushing);
this(file, false, option, strictFlushing);
}

public SequentialWriter(File file, boolean readable, SequentialWriterOption option, boolean strictFlushing)
Expand Down
3 changes: 1 addition & 2 deletions test/unit/org/apache/cassandra/io/util/SequentialWriterReadableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.junit.Test;

import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.io.compress.BufferType;

import static org.junit.Assert.*;

Expand Down Expand Up @@ -261,4 +260,4 @@ public void testExistingFileWithReadableFalse() throws IOException
tempFile.tryDelete();
}
}
}
}