Skip to content

Conversation

@MarkWolters
Copy link
Contributor

@MarkWolters MarkWolters commented Jul 14, 2025

This PR introduces a new github workflow and associated code to perform automated regression testing across branches. The workflow can be triggered manually with the branches to compare included as inputs. It is also triggered to run automatically when a PR to main is opened, in which case it will run a regression test comparing the requested branch with main.

Metrics compared include QPR, average latency, and recall at k10. See attached for an example of the output.
benchmark_report.zip

@marianotepper
Copy link
Collaborator

I suggest editing the description of this PR with a high-level explanation of what it contains/does. It would be great if it also contained an example of the output.

@MarkWolters MarkWolters marked this pull request as ready for review July 16, 2025 15:49
@MarkWolters
Copy link
Contributor Author

@tlwillke @marianotepper are we good to merge this or are there changes you would like to see?

@marianotepper marianotepper self-requested a review September 15, 2025 18:13
marianotepper
marianotepper previously approved these changes Sep 15, 2025
Copy link
Collaborator

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to merge. We can continue improving this feature as we use it, but it is a solid starting point.

Copy link
Collaborator

@tlwillke tlwillke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exit 0
fi

# Determine available memory and set heap size to half of it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check that this setting will take priority over the Xmx set in the module's pom.xml (statically set to 14GB).

@marianotepper marianotepper self-requested a review September 17, 2025 14:39
@tlwillke tlwillke merged commit 817a25c into main Sep 17, 2025
12 checks passed
@tlwillke tlwillke deleted the github_actions branch September 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants