Skip to content

Conversation

@marianotepper
Copy link
Collaborator

Given a vector quantizer, this PR introduces mechanisms to compute the reconstruction error for samples of vectors. The reconstruction error is basically the mean squared error (MSE) for each vector. This PR is part of #565.

For using the MSE, we need to consider that the norm of the vector will influence the MSE, so users might want to consider normalizing the errors.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

@marianotepper
Copy link
Collaborator Author

marianotepper commented Nov 18, 2025

The test failures are coming from somewhere else. The code in the PR seems to be sound. Edit: linking the corresponding issue #568

@marianotepper marianotepper marked this pull request as ready for review November 18, 2025 13:00
@MarkWolters MarkWolters merged commit 29a943e into main Nov 18, 2025
2 of 12 checks passed
@MarkWolters MarkWolters deleted the reconstruction-error-in-quantizers branch November 18, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants