-
Notifications
You must be signed in to change notification settings - Fork 1
DOC-4238, DOC-4510 Sideloader GA prep, Relaunch function, begin migration docs cleanup #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submitting my comments so far
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the general migration doc cleanup. Will follow up with Sideloader + approval later tonight or tomorrow morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, I left a mix of observations, optional suggestions, and error corrections. This was a really long review so I'm bound to have left some pretty eye-roll comments, so please don't feel obligated to respond to any them unless you feel like it (and have time). I trust you to make the appropriate decisions with my feedback (otherwise I wouldn't have approved). Just know that I do take the time to read responses to resolved comments 🙂.
I'll end by saying that you did some phenomenal work here. This wasn't an easy feature to document, let alone migrate to a different docset. Great job! 👏👏👏
modules/sideloader/images/copy-database-id-serverless-non-vector.png
Outdated
Show resolved
Hide resolved
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Build failure! ❌
|
Build successful! ✅
Deploying draft. |
Build successful! ✅
Deploying draft. |
For Azure in the migration section (https://d5rxiv0do0q3v.cloudfront.net/doc-4238/data-migration/sideloader/migrate-sideloader.html), it says that Azure is in private preview. Can we get rid of that preview language for GA? I believe everything will be GA (except flexible PCU which has its own section and notes) and we don't need sideloader cloud specific preview notes any longer. Does that make sense? |
Build successful! ✅
Deploying draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you April!
Direct changes for Sideloader GA
Prepare for Sideloader GA (DOC-4238):
General migration doc cleanup
Begin general cleanup of the migration docs:
includes
the entire body of cassandra-data-migrator.adoc.ifdef
and{imageprefix}
The following pages will receive further edits in future PRs. They don't need a detailed review at this time:
This PR is dependent on:
Serverless sideloader PR: https://github.com/riptano/astra-vector-docs/pull/894
Unhide sideloader PR: https://github.com/riptano/datastax-docs-site/pull/265
(DONE) The PCU PRs: