Add commons dependency #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinath-ctds
approved these changes
Aug 1, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.0_ds #115 +/- ##
=========================================
Coverage ? 54.46%
Complexity ? 118
=========================================
Files ? 19
Lines ? 940
Branches ? 80
=========================================
Hits ? 512
Misses ? 411
Partials ? 17 🚀 New features to boost your workflow:
|
srinath-ctds
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The transitive dependency
commons-configuration:commons-configurationwas previously included inorg.apache.pulsar, and indirectly used here. However, this dependency has since been removed from Pulsar with the change, resulting in missing runtime classes for components that rely oncommons-configuration.Fix
To address this, the dependency on commons-configuration is now being explicitly added to the pom of this project. This ensures continued functionality and avoids any runtime issues caused by the missing library.