Feat/unify result order #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up first to always have difference >= 0 and ratio <= 1
AmineMahiddine
approved these changes
Oct 8, 2025
Contributor
AmineMahiddine
left a comment
AmineMahiddine
left a comment
There was a problem hiding this comment.
LGTM, Nice contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing the disparity, the results will be more consistent
For difference metrics, the privileged group will be put first, so that disparity is always > 0
For ratio metrics, the privileged group will be put last so that disparity is always < 1 (and > 0)
This will avoid negative numbers in the ranking results, or unbound floats