Skip to content

feat: remove skip_image_scan #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puehringer merged 1 commit into from
Aug 11, 2025
Merged

feat: remove skip_image_scan #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/build-docker-artifacts-config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@
"type": "string",
"description": "ECR repository to push the image to"
},
"skip_image_scan": {
"type": "boolean",
"default": false,
"description": "[Deprecated: use scan_high_severity or the .trivyignore file instead] Skip scanning the image for vulnerabilities"
},
"scan_high_severity": {
"type": "boolean",
"default": true,
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/build-docker-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ on:
type: boolean
required: false
default: true
skip_image_scan:
type: boolean
required: false
default: false
scan_high_severity:
description: 'Include high severity'
type: boolean
Expand Down Expand Up @@ -258,7 +254,6 @@ jobs:
echo "severity=HIGH,CRITICAL" >> "$GITHUB_OUTPUT"
fi
- name: Run Trivy vulnerability scanner
if: ${{ inputs.skip_image_scan != true && fromJson(vars.SKIP_IMAGE_SCAN || 'false') != true && matrix.component.skip_image_scan != true }}
uses: aquasecurity/[email protected]
with:
image-ref: ${{ vars.DV_AWS_ECR_REGISTRY }}/${{ matrix.component.ecr_repository }}:${{ matrix.component.image_tag }}
Expand Down