Skip to content

feat: Disable noUncheckedIndexedAccess since it forces ! anyway #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Disable noUncheckedIndexedAccess since it forces ! anyway #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/tsconfig.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"allowSyntheticDefaultImports": true,
"preserveWatchOutput": true,
"strict": true,
"noUncheckedIndexedAccess": true,
"noUncheckedIndexedAccess": false,
Copy link
Contributor

@puehringer puehringer Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this and it does effect non arrays as well, i.e. simple objects: https://www.typescriptlang.org/tsconfig/#noUncheckedIndexedAccess

I don't want to disable it for object access, as I think it is crucial there. Any alternative @dvmoritzschoefl?

"noImplicitReturns": true,
},
// Old "moduleResolution": "Node" option required for Cypress
Expand Down