Skip to content

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Feb 27, 2025

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Automatically minimizes images (png, jpg, svg, ...) using the image-minimizer-webpack-plugin, in order to optimize bundle size.
    • Breaking change I noticed: SVGs are now "space-filling", i.e. if you gave one a specific height/width and it now cuts those borders, the SVG will look stretched. But I guess we just have to through the apps and fix this anyways.
  • ❗ The plugin is currently not fully compatible with rspack: https://rspack.dev/guide/compatibility/plugin

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant