-
Notifications
You must be signed in to change notification settings - Fork 210
feat: mysql chunking optimisation #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saksham-datazip
wants to merge
34
commits into
staging
Choose a base branch
from
feat/mysql-chunking-optimization
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 32 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
83ebf36
feat: mysql chunking optimization
saksham-datazip f5766f8
mysql optimization comment resolve
saksham-datazip 443cf94
Merge branch 'staging' into feat/mysql-chunking-optimization
saksham-datazip 6fc574c
Merge branch 'staging' into feat/mysql-chunking-optimization
saksham-datazip c09aee8
chore: formatting fix
saksham-datazip 53520de
my-sql-chunking-formatting-resolved
saksham-datazip 3b9fbe7
mysql-chunking-self-reviewed
saksham-datazip 8e4ba6a
mysql-chunking-optimization-for-string-pk
saksham-datazip 1707ae1
Merge branch 'staging' into feat/mysql-chunking-optimization
saksham-datazip feca5a0
Merge branch 'staging' into feat/mysql-chunking-optimization
vaibhav-datazip ccfb371
feat: solved lint issue
saksham-datazip fe4b4b2
Merge branch 'staging' into feat/mysql-chunking-optimization
saksham-datazip 910246a
feat: mysql chunking optimization review resolved
saksham-datazip 1eacf5a
feat: resolving-lint-extra-spaces
saksham-datazip 964a2ee
feat: lint error resolved
saksham-datazip 11a9f03
feat: self-reviewed
saksham-datazip 348c21a
Merge branch 'staging' into feat/mysql-chunking-optimization
vaibhav-datazip 94a6fd8
feat: recommiting the logical issue in mysql chunking calculation
saksham-datazip aa03463
Merge branch 'staging' into feat/mysql-chunking-optimization
ImDoubD-datazip bc1abf8
Merge branch 'staging' into feat/mysql-chunking-optimization
saksham-datazip 6e5e82f
feat: added splitviaprimarykey function
saksham-datazip d9189b9
chore: Merge branch 'feat/mysql-chunking-optimization' of https://git…
saksham-datazip 69a1714
chore: improved formatting and resolved calculating validationcount q…
saksham-datazip 96b5689
chore: merge conflict resolved
saksham-datazip 66749dd
chore: constant size readjusted
saksham-datazip fa24a2c
chore: saperated buildChunkConditionMySQL function from mssql
saksham-datazip 8411568
chore: fixed buildChunkConditionMySQL function for multiple colummns
saksham-datazip 64f31c1
chore: resolved comment for final-testing
saksham-datazip debd4eb
chore: resolved lint error
saksham-datazip 86a2d91
fix: changes pulled from staging
saksham-datazip 8ead67e
chore: float and uint8 issue resolved
saksham-datazip 0caf2aa
chore: converted float64 to int64
saksham-datazip 8ccfdd6
chore: added uint8[] block and took datatype for numeric value from i…
saksham-datazip 7754d72
chore: self reviewed
saksham-datazip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did we choose these distribution factors ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is an assumption and airbyte used it as well