test(shared,frontend): Add unit test coverage for schemas, API client, and storeAction

[enko]

Summary

• Set up vitest in packages/shared/ with node environment for pure-logic schema tests
• Add 43 tests for shared package: PasswordSchema, CircleInputSchema, EncounterInputSchema, PhoneInputSchema, EmailInputSchema, UrlInputSchema, DateInputSchema, SocialProfileInputSchema, ProfessionalHistoryInputSchema, and normalizePhoneNumber
• Add 21 tests for frontend: apiRequest (auth headers, content types, error handling, credentials) and storeAction (loading state, success/error flows, re-throw behavior)

Test plan

• cd packages/shared && pnpm vitest run — 43 tests pass
• cd apps/frontend && pnpm vitest run — 21 tests pass
• pnpm test — full monorepo suite passes (including backend + PHP)

Closes #117

🤖 Generated with Claude Code

[github-actions]

⚠️ Testing: Assertions in bare catch can pass silently

If the second apiRequest() call doesn't throw (e.g. due to a future mock refactor), the catch block is skipped and all three expect() calls inside it are silently omitted — the test still passes. The same pattern appears at the equivalent block below (line ~181).

Suggested fix — use .rejects.toMatchObject() to assert both the throw and its properties in one guaranteed step:

await expect(apiRequest('/api/test')).rejects.toMatchObject({
  statusCode: 422,
  message: 'Validation failed',
  code: 'VALIDATION_ERROR',
});

Apply the same refactor to the second error test (lines ~172-188).

[github-actions]

Commit 01f4f30 | Reviewed 2026-03-08 | Status: Approved. Critical: 0, Important: 0, Suggestion: 1. Solid test additions closing 117. 64 new tests across shared and frontend. The previously flagged bare-catch issue was fixed. One suggestion: DateInputSchema in friends.test.ts only covers valid inputs - no negative test cases for invalid date formats or date_type values, unlike every other schema in the same file.

[github-actions]

⚠️ Found 1 issue to consider. See inline comments for details.

[github-actions]

Update to summary: commit 18b2cb6 reviewed. No new issues found in d5a7164 refactor commit. Pre-existing catch-block issue remains.

[github-actions]

No new issues found in the refactor commit (d5a7164). The toHaveProperty(summary) change is a clean improvement. The pre-existing catch-block issue from the previous review remains open.

[github-actions]

💡 Testing: DateInputSchema only covers valid inputs

Unlike the other schemas in this file, DateInputSchema has no negative test cases. Consider adding tests for invalid inputs to maintain consistent coverage:

it('rejects an invalid date format', () => {
  const result = DateInputSchema({
    date_value: '15-05-1990', // DD-MM-YYYY instead of YYYY-MM-DD
    date_type: 'birthday',
  });
  expect(result.summary).toContain('invalid');
});

it('rejects an invalid date_type', () => {
  const result = DateInputSchema({
    date_value: '1990-05-15',
    date_type: 'graduation', // not a valid type
  });
  expect(result.summary).toBeDefined();
});

[github-actions]

Code review complete at commit 01f4f30. No critical or important issues found. One suggestion posted inline regarding DateInputSchema missing negative test cases.

[github-actions]

Code review complete at commit af79c73. No new issues found. Previously flagged catch-block concern in client.test.ts is resolved in the current state (all error tests use rejects.toMatchObject/rejects.toThrow). Pre-existing DateInputSchema suggestion remains open (inline comment on friends.test.ts:128).

[github-actions]

🎉 This PR is included in version 2.65.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀