chore: migrate integration test helpers from process.env to vi.stubEnv#133
Merged
chore: migrate integration test helpers from process.env to vi.stubEnv#133
Conversation
Replace fragile process.env assignments and delete statements with Vitest's vi.stubEnv() and vi.unstubAllEnvs() API across all four integration test helper files. This ensures env variables are restored atomically even if tests crash before afterAll runs, and brings all helpers into consistency with health.test.ts (reference implementation). Files migrated: - auth.helpers.ts - friends.helpers.ts - search.helpers.ts - postgis.helpers.ts https://claude.ai/code/session_01SxmmhKAEjzLfZJv8GaFmCs
🔍 Automated Code Review
FindingsNo issues found. AGENTS.md Compliance
SummaryClean, focused refactoring that correctly migrates all four integration test helpers from manual 🤖 Automated review by Claude Code • View CI Run |
|
🎉 This PR is included in version 2.67.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace fragile process.env assignments and delete statements with
Vitest's vi.stubEnv() and vi.unstubAllEnvs() API across all four
integration test helper files. This ensures env variables are restored
atomically even if tests crash before afterAll runs, and brings all
helpers into consistency with health.test.ts (reference implementation).
Files migrated:
https://claude.ai/code/session_01SxmmhKAEjzLfZJv8GaFmCs