feat(action): add action to create GCP Projects#13
Merged
tdabasinskas merged 1 commit intodatolabs-io:mainfrom Mar 21, 2025
Merged
feat(action): add action to create GCP Projects#13tdabasinskas merged 1 commit intodatolabs-io:mainfrom
tdabasinskas merged 1 commit intodatolabs-io:mainfrom
Conversation
tfhartmann
force-pushed
the
adding-create-project
branch
2 times, most recently
from
abf074f to
ca35bbb
Compare
tdabasinskas
requested changes
Mar 21, 2025
Member
There was a problem hiding this comment.
Hi @tfhartmann,
Appreciate the contribution! I've fixed the issues with failing pipeline and also added few minor comments. If you could address these, I'm more than happy to get this merged.
workspaces/scaffolder-backend-module-gcp/plugins/scaffolder-backend-module-gcp/README.md
Outdated
Show resolved
Hide resolved
...ackend-module-gcp/plugins/scaffolder-backend-module-gcp/src/actions/create-project/create.ts
Show resolved
Hide resolved
auto-merge was automatically disabled
March 21, 2025 17:36
Head branch was pushed to by a user without write access
tfhartmann
force-pushed
the
adding-create-project
branch
2 times, most recently
from
4dda450 to
61b7f95
Compare
Contributor
Author
|
Thanks @tdabasinskas hows this look? |
tfhartmann
force-pushed
the
adding-create-project
branch
from
61b7f95 to
b513f19
Compare
Allows for software templates to be created to create projects if the SA has permission to do so. docs(readme): update GCP project creation instructions and add usage example fix(gcp): remove unnecessary console log in create project action refactor: implement pr feedback fix(deps): dedup yarn.lock fix(prettier): fixing formatting
tfhartmann
force-pushed
the
adding-create-project
branch
from
b513f19 to
fa55854
Compare
tdabasinskas
approved these changes
Mar 21, 2025
Member
tdabasinskas
left a comment
tdabasinskas
left a comment
There was a problem hiding this comment.
Looks great - thanks again for a contribution! 🚀
Contributor
Author
no problem! i've actually a few more in mind too 😄 |
Contributor
Author
|
@tdabasinskas it looks like the release didn't work? 😢 |
Member
Thanks for a heads-up, fixed - https://www.npmjs.com/package/@datolabs/plugin-scaffolder-backend-module-gcp/v/0.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for software templates to be created to create projects if the SA has permission to do so.