-
Notifications
You must be signed in to change notification settings - Fork 331
Obsidian-style foldable callout syntax (e.g. "![Info]- Title") ( Duplicate of #1060) #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcchehab
wants to merge
10
commits into
datopian:main
Choose a base branch
from
marcchehab:foldable-callouts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−6
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
13a3e3b
Support for Obsidian-style foldable callout syntax (e.g. "![Info]- Ti…
marcchehab 5156929
Update remark-callouts.ts
marcchehab d0250ac
Small arrows to indicate fold-state
marcchehab a5ddfd4
Solution for adding event listener
marcchehab 87f48ad
implementing @mohamedsalem401 suggestions
marcchehab 7484585
update adding react-jsx to compileoptions in packages/remark-callouts
marcchehab cf2699d
adding color to fold indicator
marcchehab 1056fff
Applying @olayway's suggestions from code review
marcchehab 43f8561
@olayway's suggestion positioning the arrow
marcchehab 943866a
Merge pull request #2 from datopian/main
marcchehab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| export * from "./lib/remark-callouts"; | ||
| export { default } from "./lib/remark-callouts"; | ||
| export { Callout } from "./lib/Callout"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { useRef } from "react"; | ||
|
|
||
| const Callout = ({ className, children }) => { | ||
| // If it's not a foldable callout, just render it as a blockquote | ||
| if (!className.includes("callout-foldable")) { | ||
| return <blockquote className={className}>{children}</blockquote>; | ||
| } | ||
|
|
||
| const elem = useRef(null); | ||
|
|
||
| const handleClick = () => { | ||
| elem.current.classList.toggle("callout-folded"); | ||
| }; | ||
|
|
||
| return ( | ||
| <blockquote className={className} ref={elem} onClick={handleClick}>{children}</blockquote> | ||
| ); | ||
| }; | ||
|
|
||
| export { Callout }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.