Skip to content

CSV embed using wiki-link transclusion format #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CSV embed using wiki-link transclusion format #1287

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
969a7c6
[#1233 extend feature][xs] Adding markdown-transclusion.
gradedSystem Aug 22, 2024
2941128
[#1233 add test cases][m] Adding test cases for csv.
gradedSystem Aug 28, 2024
9959bff
[#1233 fix test cases][s] Resolving the issues with test cases.
gradedSystem Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/remark-wiki-link/src/lib/fromMarkdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,12 @@ function fromMarkdown(opts: FromMarkdownOptions = {}) {
width: '100%',
src: `${hrefTemplate(link)}#toolbar=0`,
};
} else if (format === 'csv') {
// CSV support
wikiLink.data.hName = 'FlatUiTable';
wikiLink.data.hProperties = {
data: { url: hrefTemplate(link) },
};
} else {
const hasDimensions = alias && /^\d+(x\d+)?$/.test(alias);
// Take the target as alt text except if alt name was provided [[target|alt text]]
Expand Down
5 changes: 5 additions & 0 deletions packages/remark-wiki-link/src/lib/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ function html(opts: HtmlOptions = {}) {
link
)}#toolbar=0" class="${classNames}" />`
);
} else if (format === 'csv') {
// CSV support
this.tag(
`<FlatUiTable data={{ url: "${hrefTemplate(link)}" }} />`
);
} else {
const hasDimensions = alias && /^\d+(x\d+)?$/.test(alias);
// Take the target as alt text except if alt name was provided [[target|alt text]]
Expand Down
1 change: 1 addition & 0 deletions packages/remark-wiki-link/src/lib/isSupportedFileFormat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const supportedFileFormats = [
"avif",
"ico",
"pdf",
"csv",
];

export const isSupportedFileFormat = (filePath: string): [boolean, string] => {
Expand Down