fix: move authentication when factory is in use. #65
+28
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there is still something I need to learn about how factory are supposed to work and the fact that I need to panic at some point if something does not work since I can't gracefully return an error is a sign of that but this commit fixes @ecv report about not being able to run `--help` and `help` command because they requires authentication. A valid concern!
ecv
approved these changes
Jan 16, 2026
scotwells
approved these changes
Jan 16, 2026
Contributor
scotwells
left a comment
scotwells
left a comment
There was a problem hiding this comment.
Just making sure I understand this change correctly. The REST client is now lazily loaded when the command needs it instead of it being built when the factory is initialized?
Collaborator
Author
|
Yes exactly
Il 16 gennaio 2026 18:20:47 CET, Scot Schuchert-Wells ***@***.***> ha scritto:
…
@scotwells approved this pull request.
Just making sure I understand this change correctly. The REST client is now lazily loaded when the command needs it instead of it being built when the factory is initialized?
--
Reply to this email directly or view it on GitHub:
#65 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is still something I need to learn about how factory are
supposed to work and the fact that I need to panic at some point if
something does not work since I can't gracefully return an error is a
sign of that but this commit fixes @ecv report about not being able to
run
--helpandhelpcommand because they requires authentication.A valid concern!