Skip to content

Conversation

@JoseSzycho
Copy link
Contributor

This PR updates the Contact CRD, giving Name and FamilyName to be optional.

This change was requested on Nov 5 Sync, as Newsleet contacts may not include these fields.

@joggrbot
Copy link
Contributor

joggrbot bot commented Nov 6, 2025

📝 Documentation Analysis

Joggr found 1 outdated docs in the pull request.

Autofix

Joggr opened 1 pull request(s) to fix the outdated docs.

Outdated

file reason confidence
docs/api/notification.md The document currently describes familyName and givenName in the Contact spec as present but not required, whereas the code changes remove the requirement from the CRD schema and make them optional in the Go type. If the documentation previously claimed they were required or fails to clarify their now-optional status, this represents a moderate risk of confusion for users referencing field requirements. 60.8%

✅ Latest commit analyzed: 0b0cd7e | Powered by Joggr

@JoseSzycho JoseSzycho merged commit 37aa87f into main Nov 6, 2025
8 of 9 checks passed
@JoseSzycho JoseSzycho deleted the chore/contact-CRD branch November 6, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants