Enhance Contact Ownership Validation Security and Observability #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by removing the private visibility check.
…correct handling of missing subject references.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the security and observability of contact ownership validation in the notification webhook system. It addresses a critical security gap and adds comprehensive logging for debugging authorization issues.
Fixed a security vulnerability where contacts without subjectRef were allowed when accessed through user control plane APIs.
Removed the check that prevented creating ContactGroupMembershipRemoval resources for private contact groups. This allows users to remove themselves from private groups they're members of, in order to follow Loops workflows.
Related to: