Skip to content

feat: Introduce SearchQuery API and Refine Indexing Infrastructure#50

Merged
JoseSzycho merged 21 commits intomainfrom
24-search-query
Mar 4, 2026
Merged

feat: Introduce SearchQuery API and Refine Indexing Infrastructure#50
JoseSzycho merged 21 commits intomainfrom
24-search-query

Conversation

@JoseSzycho
Copy link
Copy Markdown
Contributor

Pull Request: Introduce SearchQuery API and Refine Indexing Infrastructure

Description

This PR introduces the SearchQuery API, enabling full-text search capabilities against Meilisearch through the Kubernetes aggregated API server. It also includes several refinements to the indexing infrastructure, RBAC, and logging.

Key Features

1. SearchQuery API Implementation

  • New SearchQuery Resource: Added the SearchQuery virtual resource in pkg/apis/search/v1alpha1.
  • REST Storage: Implemented the REST storage for SearchQuery in internal/registry/searchquery/rest.go, handling:
    • Integration with Meilisearch MultiSearch API.
    • Robust JWT-based pagination using continue tokens that validate against the original search parameters.
    • Centralized management of the JWT signing secret in the main application entry point.
  • API Server Integration: Updated the aggregated API server to register the searchqueries endpoint.

Fixes

1. Indexer and Cache Refinements

  • Centralized Cache Sync: Refactored the PolicyCache to use a centralized startup and synchronization mechanism based on controller-runtime.

2. Infrastructure and Tools

  • RBAC Enhancements: Added comprehensive RBAC rules for the resource-indexer, including cluster-wide permissions to get/list/watch resources.

Note

Commit 52f2517 contains the actual new feature

@JoseSzycho JoseSzycho requested a review from scotwells February 25, 2026 15:55
@JoseSzycho JoseSzycho linked an issue Feb 25, 2026 that may be closed by this pull request
@JoseSzycho JoseSzycho changed the title 24 search query feat: Introduce SearchQuery API and Refine Indexing Infrastructure Feb 25, 2026
Copy link
Copy Markdown
Contributor

@scotwells scotwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting some early feedback in! Will try and take a look at the Resource embed thing shortly.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Feb 27, 2026

CLA assistant check
All committers have signed the CLA.

@JoseSzycho JoseSzycho requested a review from scotwells March 4, 2026 18:35
@JoseSzycho
Copy link
Copy Markdown
Contributor Author

@scotwells Thank you for the review. All changes were made.

This PR also received some commits that fixed some deployment issues, that's why you might see some unrelated code changes.

In the future, I will be more clean.

@JoseSzycho JoseSzycho enabled auto-merge March 4, 2026 18:40
@github-project-automation github-project-automation bot moved this from Backlog to Ready in Searching Resources in Milo Mar 4, 2026
@JoseSzycho JoseSzycho merged commit 5eb3d06 into main Mar 4, 2026
7 checks passed
@JoseSzycho JoseSzycho deleted the 24-search-query branch March 4, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement search query API

2 participants