fix: remove unused placeholder secrets and standardize meilisearch auth#61
Merged
fix: remove unused placeholder secrets and standardize meilisearch auth#61
Conversation
Remove envFrom secretRef placeholders that required non-existent secrets to be created by operators. These were causing pod startup failures (CreateContainerConfigError) in production deployments. Changes: - Remove search-apiserver envFrom placeholder from apiserver deployment - Remove search-controller-manager envFrom placeholder from controller - Remove search-indexer envFrom placeholder from resource-indexer - Standardize MEILISEARCH_API_KEY to use meilisearch-master-key secret (created by meilisearch deployment) instead of component-specific secrets Operators can still inject additional environment variables by patching the deployments directly via kustomize overlays.
scotwells
force-pushed
the
fix/remove-placeholder-secrets
branch
from
2456d8d to
7c47949
Compare
Contributor
Author
Related PRsThe infra repo has a corresponding PR that removes the now-redundant patches: Merge order:
|
zachsmith1
approved these changes
Mar 5, 2026
github-project-automation
bot
moved this from Backlog
to Ready
in Searching Resources in Milo
github-project-automation
bot
moved this from Ready
to Done
in Searching Resources in Milo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
envFrom: secretRefplaceholders from all deploymentsMEILISEARCH_API_KEYto usemeilisearch-master-keysecretProblem
Deployments referenced secrets that were never created, causing pods to fail with
CreateContainerConfigError:search-apiserversearch-controller-managersearch-indexerThese
envFrom: secretRefplaceholders were intended as extension points but required operators to create empty secrets just to start the pods.Solution
envFrom: secretRefplaceholders - operators can still inject env vars via kustomize patchesMEILISEARCH_API_KEYto referencemeilisearch-master-keysecret (created by meilisearch deployment) instead of component-specific secretsTest plan
CreateContainerConfigError