fix: respect KUBECONFIG env var in external repo fallback#27
Merged
Conversation
When consumers use the kind-bootstrap GitHub Action, the action sets the KUBECONFIG env var to the kubeconfig file it creates. The Taskfile previously ignored this env var and always fell back to the hardcoded .test-infra/kubeconfig path, causing task commands to fail. Now the external repo branch checks the KUBECONFIG env var first and only falls back to .test-infra/kubeconfig if the env var is unset or the file it points to does not exist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KUBECONFIG_FILEvariable inTaskfile.ymlto check theKUBECONFIGenvironment variable before falling back to the hardcoded.test-infra/kubeconfigpath when running from an external repo.kind-bootstrapGitHub Action, which writes the kubeconfig to its own location and setsKUBECONFIGaccordingly.Discovered in datum-cloud/unikraft-provider#2.
Test plan
taskcommands work in an external repo whenKUBECONFIGenv var is set by thekind-bootstrapaction.test-infra/kubeconfigfallback still works whenKUBECONFIGis not set🤖 Generated with Claude Code