This repository was archived by the owner on Oct 22, 2023. It is now read-only.
Add option for local model, instead of downloading it every time.#14
Closed
alfredo-f wants to merge 2 commits intodaveshap:mainfrom
Closed
Add option for local model, instead of downloading it every time.#14alfredo-f wants to merge 2 commits intodaveshap:mainfrom
alfredo-f wants to merge 2 commits intodaveshap:mainfrom
Conversation
Owner
|
I don't think this is necessary as TFHUB caches the model by default. This seems like superfluous code. It would be better to check in code at instantiation rather than set a static variable. |
Contributor
Author
|
I think this approach is a little bit more flexible:
|
75c093f to
482534a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi David,
Pre-requisites of this pull request
This pull request is meant to be merged after #13.
What
This pull request add the possibility of loading the embedding model from a local folder, instead of having to download it every time you need to spin up the microservice.
How
ARE_YOU_TESTING__LOAD_MODEL_LOCALinutils.pytensorflow.saved_modelREADME.md