Fix camelCase convertion and remove List.fold_left in style_tag#556
Merged
Fix camelCase convertion and remove List.fold_left in style_tag#556
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
New nightly version has been published to the NPM registry: @davesnx/styled-ppx@0.56.1-f574e46.0. |
davesnx
added a commit
that referenced
this pull request
Jun 3, 2025
* Remove List.fold_left in get_string_style_hashes * Remove String.make on camelCaseToKebabCase * Push benchmark for CSS * Use List.iteri instead of ref first * Remove dep on benchmark * Add random message in benchmark main * Use ubuntu-latest * Update version ocaml/setup-ocaml * Push more ubuntu-latest in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two problems affecting the performance of a hot path in native rendering:
get_string_style_hashes8b5ee07Small benchmark result embedded in this PR
Testing with 5000 hashes + 2000 camelCase conversions