Reduce parser conflicts and add comprehensive tests #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grammar refactoring to reduce Menhir conflicts: - Eliminate all reduce/reduce conflicts (4 states → 0) - Reduce shift/reduce conflicts (52 states → 28) Key changes: - Merge overlapping rule alternatives (style_rule, keyframes, declarations) - Unify pseudo_class_selector FUNCTION alternatives - Factor attribute_selector using attr_matcher_part helper - Remove redundant SEMI_COLON? from brace_block and other rules - Simplify complex_selector using list() instead of two alternatives Add 264 comprehensive parser tests covering: - Selectors (type, class, ID, universal, attribute, compound) - Combinators (descendant, child, adjacent, general sibling) - Pseudo-classes and pseudo-elements - CSS nesting with ampersand - At-rules (@media, @Keyframes, @charset, @import, @supports) - Declarations, CSS variables, and !important
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 5. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Key grammar changes
style_rule,keyframes,declarations)pseudo_class_selectorFUNCTION alternatives usingrelative_selector_listattribute_selectorusingattr_matcher_parthelperSEMI_COLON?frombrace_blockand other rulescomplex_selectorusinglist()instead of two alternativesTest coverage
New comprehensive tests covering:
!importantNotes
The remaining 28 shift/reduce conflicts are structural - they stem from
WSbeing both a meaningful token (value: | WS { Whitespace }) and an optional separator (WS?). Further reduction would require fundamental changes to whitespace handling.