Housekeeping #23
Housekeeping #23
Conversation
- sorting `package.json` fields - adding `files` field
- adding strict pragmas
- dynamic recognition of `next` callback
davidbanham
left a comment
davidbanham
left a comment
There was a problem hiding this comment.
Looks great in general, thanks! Just have a couple questions on the refactor internals commit.
| return Object.keys(source).reduce((acc, key) => { | ||
| const value = source[key]; | ||
| return Object.assign(acc, { [key]: value }); | ||
| }, dest); |
There was a problem hiding this comment.
Can you expand on the reason for this refactor?
There was a problem hiding this comment.
I thought reduce serves better purpose conveying message to the reader because source object is reduced (Yeah it is mapped but every mapper is in fact a reducer) to destination one. Plus reduce has return value compared to forEach which I thought is neat and leveraged here.
| const originalParam = Router.prototype.constructor.param; | ||
| Router.prototype.constructor.param = function param(name, fn) { | ||
| fn = wrap(fn); | ||
| return originalParam.call(this, name, fn); |
There was a problem hiding this comment.
Do we not change the value of this by removing this section from the wrap closure?
There was a problem hiding this comment.
Value of this in this case is determined by Router#param callsite and explicitly forwarded to original implementation using .call binding so it is preserved. Moving it out of a function doesn't change it.
2 participants
This PR brings in following changes:
.editorconfig.gitignore, ESLint & Travis CI confignpmleftovers - completed migration toyarnnextcallback resolution)