Feat/interface impl #533
Open
Feat/interface impl #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Norbytus
commented
Jul 20, 2025
| @@ -28,8 +28,17 @@ pub struct StructAttributes { | |||
|
|
|||
| #[derive(FromMeta, Debug)] | |||
| pub struct ClassEntryAttribute { | |||
| ce: syn::Expr, | |||
| stub: String, | |||
| pub ce: syn::Expr, | |||
There was a problem hiding this comment.
Make pub cause not see necessary to duplicate
Norbytus
commented
Jul 20, 2025
| @@ -131,6 +131,41 @@ impl<'a> Function<'a> { | |||
| format_ident!("_internal_{}", &self.ident) | |||
| } | |||
|
|
|||
| pub fn abstract_function_builder(&self) -> TokenStream { | |||
There was a problem hiding this comment.
Make new builder, cause for interface we don't need a CallType
Norbytus
commented
Jul 20, 2025
|
|
||
| impl CleanPhpAttr for Vec<Attribute> { | ||
| fn clean_php(&mut self) { | ||
| self.retain(|attr| !attr.path().is_ident("php")); |
There was a problem hiding this comment.
Just tired write retain for php everywhere))
Norbytus
commented
Jul 20, 2025
| @@ -125,7 +125,7 @@ struct ParsedImpl<'a> { | |||
| } | |||
|
|
|||
| #[derive(Debug, Eq, Hash, PartialEq)] | |||
| enum MethodModifier { | |||
| pub enum MethodModifier { | |||
There was a problem hiding this comment.
Make public to not duplicate
Norbytus
commented
Jul 20, 2025
| @@ -141,7 +141,7 @@ impl quote::ToTokens for MethodModifier { | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| struct FnBuilder { | |||
| pub struct FnBuilder { | |||
There was a problem hiding this comment.
Make public to not duplicate
Norbytus
commented
Jul 20, 2025
| @@ -151,13 +151,19 @@ struct FnBuilder { | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| struct Constant<'a> { | |||
| pub struct Constant<'a> { | |||
There was a problem hiding this comment.
Make public to not duplicate
Norbytus
force-pushed
the
feat/interface_impl
branch
2 times, most recently
from
df8ad81 to
8a46b3a
Compare
Pull Request Test Coverage Report for Build 16880353614Details
💛 - Coveralls |
Norbytus
commented
Jul 21, 2025
| #[php_interface] | ||
| #[php(extends(ce = ce::throwable, stub = "\\Throwable"))] | ||
| #[php(name = "ExtPhpRs\\Interface\\EmptyObjectInterface")] | ||
| pub trait EmptyObjectTrait |
There was a problem hiding this comment.
@Xenira you test for expand, i try make same as you in enum. But get error, i miss something, but idk what)
Norbytus
force-pushed
the
feat/interface_impl
branch
5 times, most recently
from
1cdd123 to
2abe85f
Compare
Norbytus
force-pushed
the
feat/interface_impl
branch
from
c4f06b9 to
a1a49ca
Compare
For classes with interface flags, declare __construct as abstract method
Norbytus
force-pushed
the
feat/interface_impl
branch
from
a1a49ca to
b98feae
Compare
Norbytus
force-pushed
the
feat/interface_impl
branch
from
f28ffa1 to
b5788e1
Compare
Norbytus
force-pushed
the
feat/interface_impl
branch
from
b5788e1 to
3f709ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
❤️ Thank you for your contribution!