Skip to content

Conversation

Norbytus
Copy link
Contributor

@Norbytus Norbytus commented Jul 20, 2025

Description

  • Add interface registration

❤️ Thank you for your contribution!

This was referenced Jul 20, 2025
@Norbytus Norbytus force-pushed the feat/interface_impl branch 2 times, most recently from df8ad81 to 8a46b3a Compare July 21, 2025 15:59
@coveralls
Copy link

coveralls commented Jul 21, 2025

Pull Request Test Coverage Report for Build 18244744117

Details

  • 68 of 152 (44.74%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+3.0%) to 30.759%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/macros/src/lib.rs 2 5 40.0%
crates/macros/src/class.rs 0 5 0.0%
crates/macros/src/function.rs 12 20 60.0%
src/builders/class.rs 7 17 41.18%
src/describe/stub.rs 0 17 0.0%
crates/macros/src/interface.rs 43 61 70.49%
src/builders/module.rs 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
src/describe/stub.rs 1 6.51%
src/builders/class.rs 2 55.73%
Totals Coverage Status
Change from base Build 18143162569: 3.0%
Covered Lines: 1326
Relevant Lines: 4311

💛 - Coveralls

@Norbytus Norbytus force-pushed the feat/interface_impl branch 5 times, most recently from 1cdd123 to 2abe85f Compare July 23, 2025 17:55
@Norbytus Norbytus force-pushed the feat/interface_impl branch 4 times, most recently from b5788e1 to 3f709ab Compare August 10, 2025 18:06
@Norbytus Norbytus force-pushed the feat/interface_impl branch from 9e9410b to c0dcacd Compare August 18, 2025 06:35
@Xenira
Copy link
Collaborator

Xenira commented Aug 21, 2025

@Norbytus I will have a more detailed look at this this weekend and might do some tinkering myself. Is this up to date? Might push some changes directly to this branch.

@Norbytus
Copy link
Contributor Author

@Norbytus I will have a more detailed look at this this weekend and might do some tinkering myself. Is this up to date? Might push some changes directly to this branch.

You can to this branch, it's ok.
Or just can write some comment.
I still thinking about should we have separate builder for interfaces and how make optional construct.

@jakubkulhan
Copy link

Hi, this looks like there was a lot of work done, great job! Any chance this would be completed and merged? I'm thinking about using ext-php-rs for my extension and this would simplify the implementation a lot.

@Xenira
Copy link
Collaborator

Xenira commented Sep 30, 2025

@jakubkulhan had to take some time off, but will push this now that I have more time. There is some work left, but should be done soon.

Xenira added a commit to Norbytus/ext-php-rs that referenced this pull request Oct 4, 2025
@Xenira
Copy link
Collaborator

Xenira commented Oct 4, 2025

@Norbytus could you rebase onto master? I can't do this because workflow files changed and those need extra permissions to update.

@Norbytus Norbytus force-pushed the feat/interface_impl branch from 432b52b to c0a7827 Compare October 4, 2025 11:38
@Norbytus
Copy link
Contributor Author

Norbytus commented Oct 4, 2025

@Norbytus could you rebase onto master? I can't do this because workflow files changed and those need extra permissions to update.

Done

@Xenira
Copy link
Collaborator

Xenira commented Oct 4, 2025

@Norbytus will try to do some refactoring on the derives and have some minor code style adjustments in the works. Ill also add some more tests. Other than that it looks good to me. Thank you so much for your work and sorry again for the huge delay getting to this.

@Norbytus
Copy link
Contributor Author

Norbytus commented Oct 4, 2025

@Norbytus will try to do some refactoring on the derives and have some minor code style adjustments in the works. Ill also add some more tests. Other than that it looks good to me. Thank you so much for your work and sorry again for the huge delay getting to this.

No problem, i will check tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants