-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Add constructor visability #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add constructor visability #542
Conversation
51bb4ad
to
8308d26
Compare
@Xenira how i can update guide there wrong doc about private,protected, public
Should be
|
d633599
to
e360e76
Compare
Pull Request Test Coverage Report for Build 16824767628Details
💛 - Coveralls |
@Norbytus see here: ext-php-rs/guide/src/macros/impl.md Line 45 in 34caede
|
I see that variant, but it's not working)
So i think, maybe we update dock. |
Ye, docs are probably wrong there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Just some minor code style suggestions.
6c25cac
to
3adf8ff
Compare
Add visability in constructor meta, and feature mark constructor as private and protected
3adf8ff
to
a676026
Compare
Add visability in constructor meta, and feature mark constructor as private and protected
Description
Checklist
Check the boxes that apply (put an
x
in the brackets, like[x]
). You can also check boxes after the PR is created.❤️ Thank you for your contribution!