Update from upstream #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges Change bsSelect to deep watch bsOptions values.
'format` string can contain literal values. These need to be escaped by surrounding with single quotes (e.g. `"h 'in the morning'"`).
…llow for stacking The number of active modals and asides are tracked in order to set a `z-index` value that will allow those elements to be on top of each other. Currently, if two asides are shown at the same time, clicking the backdrop will hide the aside that is below the one above. Also, the backdrop of the second aside is below the first aside.
…ckdrops and dialogs ensure that only elements with backdrops (modals and asides) have the z-index value modified
…ate is rendered again after it was previously destroyed if dropdown has inline sibling template then template is saved to the options during the compile time. After dropdown is destroyed (for example it was inside the modal) and rendered again (modal reopened) - compile for dropdown is not executed and options are null. This causes error "angular TypeError: Cannot set property 'scope' of null" and dropdown loses its template. Solution is to save the template not in the options but in the attributes that are not destroyed.
Bootstrap font files were not being found when browsing the docs pages
Add support to the bsCollapseToggle directive for the disabled attribute either via standard html or ngDisabled. This is to allow individual panels to be locked either open or closed when an action is required inside a panel. For example a form may need to be completed inside a panel.
…pture groups for userAgent matching
Change title to data-title in examples and tests. This is changed because browsers display contents of title attribute when hovering over a tab in a tooltip. Existing code already accepts data-title attribute. For that reason it was only necessary to updated example code and tests. Closes @2004.
Add ‘modalClass' as an option on the modal configuration. When specified, the string will be added as a CSS class to the outer modal element. If the option isn’t specified, no class is added. Closes #1331
chore(tests) - introduce angular 1.5 and 1.6 in Travis test grid
Change-Id: Iaadb69157435bffc1a4853edad192d1dfe5e68d2
Change-Id: Ibc48538ef229ad9e2c86512d3963dd0ec17286fb
Changing the tab to handle keypress event for both space-bar and enter. The JAWS screen reader is instructing users to hit space-bar. Change-Id: I335758ca59605b7ade4be006f65d48bb3bafb4e8
Updating tabs to allow for access to the controller scope if needed. Change-Id: I7a6ee41ed6b8fc5d9988d89538291e58a6b63da3
Fixing JSHint issues with prior 508 commits.
fix(compliance): 508 Compliance Fixes
fix(datepicker): Displaying Date for timezone UTC
This fixes the case where ngModelOptions specify getterSetter: true. In that case watching the ngModel attribute does nothing useful, because it will point to a function rather than a value. - The directive no longer deep-watches the model - No deep-watching should also fix #1966
* feat(modal): 508 support in modal 508 and screen-reader support in modal. * fix(eslint): Modal eslint errors Fix the eslint erros with modal.js. * fix(modal): fix skipped tests Remove the force flag from the modal tests. * fix(modal): aria-hidden on body without backdrop Only apply the aria-hidden to the body element when the backdrop option is specified.
…ght of the page (#2238) * Use the document instead of the body to determine the height of the page * Fix var name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.