Conversation
Co-authored-by: davidfstr <764688+davidfstr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Extend lint rule to disallow pathlib imports in model layer
Extend Mar 9, 2026
no-direct-filesystem-access-in-model (C9017) to ban pathlib imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
no-direct-filesystem-access-in-modellint rule didn't coverpathlibimports, leaving a gap wherepathlib.Pathfilesystem operations could be used in the model layer undetected.Changes
src/crystal/lint/rules.py: Added checks invisit_importandvisit_importfromto flag bothimport pathlibandfrom pathlib import ...when insidecrystal/model/src/crystal/model/project.py: Fixed the one pre-existing violation — replacedpathlib.Path(...).as_uri()with'file://' + url_quote(..., safe='/')using the already-importedurl_quotetests/test_lint_rules.py: AddedTestNoDirectFilesystemAccessInModelInMemorycovering both import forms flagged inside the model layer and allowed outside it; added_run_checker_on_code_in_model/_assert_message_emitted_in_modeltest helpers that simulate a file path undercrystal/model/Example
Original prompt
Created from VS Code.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.