Fix LogDrawer slowdown from unbounded line accumulation#301
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix LogDrawer appending new lines performance issue
Fix LogDrawer slowdown from unbounded line accumulation
Mar 22, 2026
702d6f0 to
9d1d5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogDrawernever trimmed old lines from itsRichTextCtrl, so each append got progressively slower as the log grew without bound.Changes
log_drawer.py— Add_MAX_LINE_COUNT = 5000. After each batch of text is written to the textarea, trim leading lines when the count exceeds the limit using wxPython's efficient positional deletion:test_log_drawer.py— Add skipped stubtest_when_write_many_lines_to_writer_beyond_max_then_leading_lines_trimmed, consistent with existing stubs in the file.RELEASE_NOTES.md— Document under a new "Performance improvements" section.Original prompt
Created from VS Code.
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.