Fix NIA page form fields not disabled in readonly mode#302
Merged
Conversation
Co-authored-by: davidfstr <764688+davidfstr@users.noreply.github.com> Agent-Logs-Url: https://github.com/davidfstr/Crystal-Web-Archiver/sessions/da6ecc28-932b-4524-a6d3-b8aae4d2a83d
Copilot
AI
changed the title
[WIP] Fix editable field issue on NIA page for read-only projects
Fix NIA page form fields not disabled in readonly mode
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the "Not in Archive" page, 5 form input fields remained editable even when the project was opened in read-only mode — only the radio buttons and download button were correctly disabled.
Changes
special_pages.py: Add{'disabled ' if readonly else ''}to the 5 fields missing it innot_in_archive_html():cr-root-url-name(Create Root URL: Name)cr-group-url-pattern(Create Group: URL Pattern)cr-group-source(Create Group: Source)cr-group-name(Create Group: Name)cr-download-group-immediately-checkbox(Create Group: Download Immediately)test_server.py: Addtest_given_readonly_project_then_all_form_input_fields_disabledto assert each field carries thedisabledattribute in readonly mode.RELEASE_NOTES.md: Document the fix under the main branch section.Original prompt
Created from VS Code.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.