-
-
Notifications
You must be signed in to change notification settings - Fork 138
hugging face basic llm endpoint is implemented #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
documentation is left i am busy that why i cant add chat model as well let me know if there is any changes required |
|
Hey @huzaifansari54, Thanks for your work! |
|
stream api is add for llms |
|
awesome, thanks! I'll try to start the review today |
|
Update on this PR? @huzaifansari54 |
|
It is under review now |
|
Tried to use it to create agent, got error: The argument type 'HuggingfaceInference' can't be assigned to the parameter type 'BaseChatModel'. dartargument_type_not_assignable final llm = HuggingfaceInference.call(
apiKey: Env.huggingFaceApiKey,
model: modelName!,
);
final tools = [tool];
final agent = ToolsAgent.fromLLMAndTools(
llm: llm,
tools: tools,
);Hope to see this PR fixed and merged soon |
|
going back to this PR soon! sorry for the delay |
|
Hey, any updates? |
|
@gemini-cli /review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This PR adds support for Hugging Face Inference API. The implementation looks good, but there are a few areas for improvement.
🔍 General Feedback
- The main points are handling of nullable responses from the API client to avoid potential runtime errors.
- Completing the
copyWithmethod inHuggingFaceOptions. - Improving the example by not hardcoding the API key.
Overall, a good contribution that extends the functionality of LangChain.dart.
Feature #19
Description
This pull request is add support for hugging face llms in lang chain
Dependencies
Updated pubspec.yaml to reflect new dependencies
Added a Huggingface_client
Testing
use an example for test the model