Skip to content

Harden footballbin-predictions skill security#372

Open
billychl1 wants to merge 3 commits intodavila7:mainfrom
billychl1:billy/footballbin-predictions-security-fix
Open

Harden footballbin-predictions skill security#372
billychl1 wants to merge 3 commits intodavila7:mainfrom
billychl1:billy/footballbin-predictions-security-fix

Conversation

@billychl1
Copy link
Contributor

@billychl1 billychl1 commented Feb 22, 2026

Summary

  • remove URL-in-table endpoint pattern that triggered security scanners
  • keep app links in SKILL.md as requested
  • harden script networking and input validation
  • remove app-download lines from CLI output

Validation

  • bash -n on scripts/footballbin.sh passes
  • no curl|bash or URL-pipe patterns remain

Summary by cubic

Strengthened the footballbin-predictions skill security and fixed CI permissions so security audit comments work for Dependabot. Fewer scanner flags and more reliable CI.

  • Area: components (cli-tool/components/skills/sports/footballbin-predictions)
  • Script: split host/path/scheme; curl uses fail/show-error/silent/max-time; validate league/team; removed app download lines; no installs
  • Docs: Quick Start → Usage; endpoint shown as Host/Path/Method; app links kept as plain lines
  • CI: security-audit skips PR comments on forks; added pull-requests: write permission to prevent Dependabot 403
  • No new components; no catalog regen; no new env vars or secrets

Written for commit dcf7ed1. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Feb 22, 2026

@billychl1 is attempting to deploy a commit to the Daniel Avila's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/component-security-validation.yml">

<violation number="1" location=".github/workflows/component-security-validation.yml:60">
P2: Dependabot PRs still run this comment step with a read-only GITHUB_TOKEN, so github.rest.issues.createComment will fail with 403 despite the same-repo check.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Dependabot PRs run with a restricted GITHUB_TOKEN that defaults to
read-only. Explicitly declaring `pull-requests: write` on the job
lets GitHub honour the permission for same-repo Dependabot PRs,
preventing the 403 on github.rest.issues.createComment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@billychl1
Copy link
Contributor Author

@cubic-dev-ai to re-run a review.

@cubic-dev-ai
Copy link
Contributor

cubic-dev-ai bot commented Feb 26, 2026

@cubic-dev-ai to re-run a review.

@billychl1 I have started the AI code review. It will take a few minutes to complete.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@billychl1
Copy link
Contributor Author

@davila7 Could you authorize the Vercel deployments for this PR? The Security Audit and code review checks are passing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant