Skip to content

[unicode] fixed warning in convert_mbstring_to_wstring()#3110

Merged
davisking merged 4 commits intodavisking:masterfrom
pfeatherstone:unicode
Aug 22, 2025
Merged

[unicode] fixed warning in convert_mbstring_to_wstring()#3110
davisking merged 4 commits intodavisking:masterfrom
pfeatherstone:unicode

Conversation

@pfeatherstone
Copy link
Contributor

@pfeatherstone pfeatherstone commented Aug 21, 2025 •
edited
Loading

This suppresses a warning that's been bugging me for a while.

@pfeatherstone
Copy link
Contributor Author

pfeatherstone commented Aug 21, 2025

Also having functions returning const std::string or const std::wstring is pointless but i'm not fixing that.

@davisking
Copy link
Owner

davisking commented Aug 22, 2025

Sweet, thanks for the PR :D

@davisking davisking merged commit ffe7881 into davisking:master Aug 22, 2025
9 checks passed
@pfeatherstone pfeatherstone deleted the unicode branch August 22, 2025 05:45
davisking pushed a commit to smu-sc-gj/dlib that referenced this pull request Aug 31, 2025
@pfeatherstone @davisking
[unicode] fixed warning in convert_mbstring_to_wstring() (davisking#3110
92d9cff 
)

* surpress warnings in convert_mbstring_to_wstring()

* fix

* fixed convert_wstring_to_mbstring as well

* Oops

---------

Co-authored-by: pfeatherstone <pfeatherstone@pf>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pfeatherstone @davisking