This repository was archived by the owner on Jun 9, 2021. It is now read-only.
Change location.hash *before* scrolling.#123
Open
sscherfke wants to merge 2 commits intodavist11:masterfrom
sscherfke:patch-1
Open
Change location.hash *before* scrolling.#123sscherfke wants to merge 2 commits intodavist11:masterfrom sscherfke:patch-1
sscherfke wants to merge 2 commits intodavist11:masterfrom
sscherfke:patch-1
Conversation
You have to update `location.hash` before scrolling or the browser history will break and not jump to the correct positions in the document.
Changing `location.hash` before scrolling fixes the browser history but breaks smooth scrolling. In order to fix both, we need to add a temporary fake link element.
|
This is not true. What browsers have you tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You have to update
location.hashbefore scrolling or the browser history will break and not jump to the correct positions in the document.